This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Sports: Fix missing possession in NFL #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SportsDescription: Placeholder - not a unique answer, but rather a shared library for other sports Example Query: [blue jays games](https://beta.duckduckgo.com/?q=blue jays games), cardinals, vikings Tab Name: Source: These are the important fields from the IA page. Please check these for errors or missing information and update the IA page This is an automated message which will be updated as changes are made to the IA page |
| @@ -65,6 +65,11 @@ | |||
| // fill boxscore with placeholder data | |||
| attrs.score = games.fillBoxscore(attrs.score, ops); | |||
|
|
|||
| // finish here if there is no possession data | |||
| if (!attrs.score.possession) { | |||
There was a problem hiding this comment.
Nice! Is it possible that attr.scores is even undefined? If so, maybe we should catch that here too.
There was a problem hiding this comment.
@b1ake given the definition of fillBoxscore it seems that it easily might be.
Will update the PR, thanks for catching it!
* The previous implementation assumed that the possession data will be always available. This might not be the case, especially when a game gets cancelled or delayed. This commit fixes the situation by skipping the part of the code that requires the possession to be filled in. Signed-off-by: mr.Shu <mr@shu.io>
mrshu
force-pushed
the
mrshu/fix-nfl-possession
branch
from
8da63d5
to
74b8c76
Compare
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your Pull Request do (check all that apply)?
Choose the most relevant items and use the following title template to name
your Pull Request.
New {IA Name} Instant AnswerSports: Fix missing possession in NFL{IA Name}: {Description of Improvements}{SpiceRole/Templates/Tests/Docs}: {Short Description}Description of changes
The previous implementation assumed that the possession data will be
always available. This might not be the case, especially when a game
gets canceled or delayed.
This commit fixes the situation by skipping the part of the code that
requires the possession to be filled in.
Which issues (if any) does this fix?
See above
People to notify (@mention interested parties)
@b1ake
Instant Answer Page: https://duck.co/ia/view/sports
Maintainer: @b1ake
The previous implementation assumed that the possession data will be
always available. This might not be the case, especially when a game
gets canceled or delayed.
This commit fixes the situation by skipping the part of the code that
requires the possession to be filled in.
Signed-off-by: mr.Shu mr@shu.io