Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle legacy setuptools projects #247

Merged
merged 3 commits into from
Feb 14, 2021
Merged

Conversation

AstraLuma
Copy link
Contributor

This will use synthesized pyproject data if it detects that it's being run in a legacy project (no pyproject.toml, but yes setup.py or setup.cfg).

Fixes #222

@duckinator
Copy link
Owner

duckinator commented Feb 10, 2021

@AstraLuma I'm okay with you adding no-else-return to disabled messages in .pylintrc, so you don't need to # noqa it. I don't really agree with that rule, just hadn't encountered it yet. (It's the disable=missing-docstring,....,invalid-name thing.)

@AstraLuma
Copy link
Contributor Author

idk what's up with FreeBSD

@duckinator
Copy link
Owner

duckinator commented Feb 10, 2021

I'm not sure. It seems to be the same problem as I encountered (and haven't fixed) in duckinator/emanate#208 earlier.

@duckinator
Copy link
Owner

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 14, 2021

Build succeeded:

@bors bors bot merged commit 39df889 into duckinator:main Feb 14, 2021
@AstraLuma AstraLuma deleted the legacy-projects branch February 15, 2021 16:16
@nbraud
Copy link
Collaborator

nbraud commented Apr 11, 2021

Ooh. I missed this PR, but thanks a bunch for the fix, @AstraLuma

@duckinator duckinator changed the title Handle the case of a legacy project. Handle legacy setuptools projects Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support projects that don't have a pyproject.toml
3 participants