Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci cleanup #208

Merged
merged 8 commits into from
Feb 14, 2021
Merged

Ci cleanup #208

merged 8 commits into from
Feb 14, 2021

Conversation

duckinator
Copy link
Owner

No description provided.

@duckinator
Copy link
Owner Author

I'm planning to change this to more closely line up with https://github.com/duckinator/bork/pull/237/files so the two projects are a bit more consistent with each other.

@nbraud
Copy link
Collaborator

nbraud commented Feb 1, 2021

LGTM so far <3

@nbraud
Copy link
Collaborator

nbraud commented Feb 5, 2021

I just rebased it for you, to resolve the merge conflict.

@nbraud
CI: Rename the meta-task
abe59af 
This is clearer (the task covers lints and tests)
and more consistent with the CI setup for Bork.
@nbraud
Cirrus: Define aliases for the task sets
e2c5b4b 
More consistent with Bork's CI setup.
@nbraud
Copy link
Collaborator

nbraud commented Feb 5, 2021

I'm planning to change this to more closely line up with Bork so the two projects are a bit more consistent with each other.

I just did that for you. ^^

@nbraud
Copy link
Collaborator

nbraud commented Feb 5, 2021 •
edited
Loading

Of course now pip3 install -U .[testing] is failing on macOS... >_>'
PS: Re-running fixed it; might have been a race condition or some filesystem garbage. Why are computers so crap?

@duckinator
Copy link
Owner Author

Whatever the problem was, it looks like it sorted itself out! Thank you for finishing this up for me. 💜

bors r+

bors bot added a commit that referenced this pull request Feb 5, 2021
@bors @duckinator @nbraud
Merge #208
0b7c7be 
208: Ci cleanup r=duckinator a=duckinator



Co-authored-by: Ellen Marie Dash <me@duckie.co>
Co-authored-by: nicoo <nicoo@mur.at>
@bors
Copy link
Contributor

bors bot commented Feb 5, 2021

Timed out.

@duckinator
Copy link
Owner Author

But why, bors?

@duckinator
Copy link
Owner Author

bors retry

bors bot added a commit that referenced this pull request Feb 6, 2021
@bors @duckinator @nbraud
Merge #208
06409da 
208: Ci cleanup r=duckinator a=duckinator



Co-authored-by: Ellen Marie Dash <me@duckie.co>
Co-authored-by: nicoo <nicoo@mur.at>
@bors
Copy link
Contributor

bors bot commented Feb 6, 2021

Timed out.

@duckinator
[.cirrus.yml] Use name: instead of `alias:
984c14a 
Also move/reformat the `container:` and `script:` lines.
@duckinator
Copy link
Owner Author

Turns out bors was confused because it was expecting a task named CI success, and using alias: CI success wasn't sufficient for that. Switched alias: to name: and I think we should be good to go. ^.^

bors r+

bors bot added a commit that referenced this pull request Feb 10, 2021
@bors @duckinator @nbraud
Merge #208
cc6d53f 
208: Ci cleanup r=duckinator a=duckinator



Co-authored-by: Ellen Marie Dash <me@duckie.co>
Co-authored-by: nicoo <nicoo@mur.at>
@bors
Copy link
Contributor

bors bot commented Feb 10, 2021

Build failed:

@duckinator
Copy link
Owner Author

FreeBSD why are you doing this to me lmao

@duckinator duckinator mentioned this pull request Feb 10, 2021
Merged
@duckinator
Copy link
Owner Author

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 14, 2021

Build succeeded:

@bors bors bot merged commit 0c01c09 into master Feb 14, 2021
@duckinator duckinator deleted the ci-cleanup branch February 14, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duckinator @nbraud