Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MinIO as storage provider #149

Closed
Lukas-Sachse opened this issue Mar 2, 2023 · 3 comments 路 Fixed by #335
Closed

Support MinIO as storage provider #149

Lukas-Sachse opened this issue Mar 2, 2023 · 3 comments 路 Fixed by #335
Labels
enhancement New feature or request help wanted Extra attention is needed released

Comments

@Lukas-Sachse
Copy link

馃殌 Feature Proposal

Add support for MinIO as storage provider.

Motivation

We have a running MinIO instance and want to use it for our remote cache.
I tried to use it with the AWS S3 Storage Provider docs, but I can't get it working.
So I think there are maybe some additional settings or steps needed.

Example

Adding specific doc section for MinIO.

@fox1t fox1t added enhancement New feature or request help wanted Extra attention is needed labels Mar 2, 2023
@eve0415
Copy link

eve0415 commented Sep 25, 2023

I don't have my AWS account so I cannot test it myself but I don't think we have to wrap endpoint around aws.Endpoint but pass it directly

...(endpoint ? { endpoint: new aws.Endpoint(endpoint) } : {}),

--- a/src/plugins/remote-cache/storage/s3.ts
+++ b/src/plugins/remote-cache/storage/s3.ts
@@ -28,8 +28,8 @@ export function createS3({
         }
       : {}),
     ...(region ? { region } : {}),
-    ...(endpoint ? { endpoint: new aws.Endpoint(endpoint) } : {}),
+    ...(endpoint ? { endpoint } : {}),
       ? { sslEnabled: false, s3ForcePathStyle: true }
       : {}),
   })

After changing the line, it should work with MinIO and Cloudflare R2 as well.

@hieuvuvan
Copy link

it related to option s3ForcePathStyle: true. i workaround using NODE_ENV=test

@matteovivona
Copy link
Collaborator

馃帀 This issue has been resolved in version 2.1.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants