Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially support minio as a provider #335

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Conversation

EWhite613
Copy link
Contributor

In this PR:

  • Support MINIO as storage provider. Can just use s3 and s3ForcePathStyle: true and it'll work

Issues reference:

Checklist:

  • x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code with pnpm lint locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
    • Any ideas on writing a good test? The s3 tests do s3ForcePathStyle for the s3 tests, and that's all Minio support requires in addition to s3. I could just copy the s3 tests and change the provider but it's gonna have the same output for that
  • Have you successfully ran build with pnpm build of your changes locally?
  • Have you successfully ran tests with pnpm test of your changes locally?
  • Have you commit using Conventional Commits?

test/minio.ts Dismissed Show resolved Hide resolved
@matteovivona
Copy link
Collaborator

@all-contributors add @EWhite613 on code

Copy link
Contributor

@matteovivona

I've put up a pull request to add @EWhite613! 🎉

Copy link
Collaborator

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you for this contribution! I think the tests are enough and we can land this!

@fox1t fox1t merged commit fd92582 into ducktors:main Mar 29, 2024
20 checks passed
@matteovivona
Copy link
Collaborator

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MinIO as storage provider
3 participants