Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whole code for consistency and efficiency #43

Open
svenstaro opened this issue Jul 17, 2011 · 4 comments
Open

Check whole code for consistency and efficiency #43

svenstaro opened this issue Jul 17, 2011 · 4 comments
Assignees
Milestone

Comments

@svenstaro
Copy link
Member

This should be done shortly before release of 0.1 because we have many inconsistencies, undocumented pieces of code and some sub optimal expressions (like many copy constructors).

Also check includes and move all includes that are only required in the .cpp to there. Keep includes that are required in both files in the header only. There are tools to suggest this automatically.

This should also be used to profile the code and check for any bottlenecks.

Depends on #12. [done]

  • inconsistencies
  • undocmented code [done]
  • copy constructors [done]
  • memory leaks [done]
  • const-correctness
  • use move operators where appropriate
  • use callgrind
@ghost ghost assigned svenstaro Jul 17, 2011
@opatut
Copy link
Member

opatut commented Jul 17, 2011

Watch out, you will not want to move all ´´´#include "Root.hpp"´´´ the the headers for circular dependency reasons.

@svenstaro
Copy link
Member Author

Good point.

@ghost ghost assigned opatut Jul 29, 2011
@svenstaro
Copy link
Member Author

All includes should be ordered the opposite way of what they are ordered now were ordered before. A good reasoning about that here.

@svenstaro
Copy link
Member Author

Added note about move operators.

@ghost ghost assigned svenstaro Aug 4, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants