Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address a few deprecation warnings #146

Merged
merged 2 commits into from Mar 2, 2019

Conversation

yarikoptic
Copy link
Member

There is still a bunch left by running the tests but they seems all to be of not our problem

@codecov-io
Copy link

codecov-io commented Mar 1, 2019

Codecov Report

Merging #146 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   83.25%   83.24%   -0.01%     
==========================================
  Files          44       44              
  Lines        2323     2322       -1     
  Branches      253      253              
==========================================
- Hits         1934     1933       -1     
  Misses        317      317              
  Partials       72       72
Impacted Files Coverage Δ
duecredit/utils.py 36.84% <100%> (-0.55%) ⬇️
duecredit/io.py 82.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8089f67...46f843e. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 86.223% when pulling 46f843e on yarikoptic:enh-deprecations into 8089f67 on duecredit:master.

@yarikoptic yarikoptic merged commit d30c3c9 into duecredit:master Mar 2, 2019
@yarikoptic yarikoptic deleted the enh-deprecations branch March 3, 2019 00:58
yarikoptic added a commit that referenced this pull request Apr 13, 2021
[0.8.0](https://github.com/duecredit/duecredit/tree/0.8.0) (2020-02-09)

- Variety of small fixes
- Added .zenodo.json for more proper citation of duecredit
- drop testing for 3.4 -- rare beast, lxml does not provide pkg for it
- Support for citing matplotlib via injection
- Address a few deprecation warnings (#146)
- Provide more informative message whenever using older citeproc without encoding arg

* tag '0.8.0': (23 commits)
  DOC: Manual changelog entry for 0.8.0
  ENH: added a debug message to report details of the request to doi.org
  Update README.md
  Make pytest verbose
  RF: took recipe from nibabel, and just rely on pip, without conda
  RF: appveyor -- just list all desired Pythons - may be it would just work by magic?
  BF: drop testing for 3.4 -- rare beast, lxml does not provide pkg for it
  BF(TST): list expected entries in sorted order (fix for matplotlib)
  Added rudimentary PR template
  ENH: Rudimentary .zenodo.json
  Add mod_matplotlib to injection tests
  Add bctpy to list of projects
  Add Matplotlib injection
  RF: use isinstance instead of type().__name__ comparison
  BF: match also for ModuleNotFoundError to not log error
  ENH: provide equality comparison for entries
  RF(TST): allow full process importing duecredit directly to fail
  ENH: Raise ValueError if either active or inactive collector is None
  RF: Import InactiveDueCreditCollector directly from stub
  Remove unused import of Iterator, seemed to cause warnings
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants