RF: remove remaining usage of SIX, and thus move away fully from Python 2 #186

a-detiste · 2023-11-09T13:18:49Z

https://wiki.debian.org/Python3-six-removal

523f547)

(ok i i did not read /CONTRIBUTING.md but I'm catching up...)

Changes

I ran tests locally and they passed
If you would like to list yourself as a DueCredit contributor and your name is not mentioned please modify .zenodo.json file.

yarikoptic · 2023-11-09T14:42:03Z

codespell - ignore, pushed fix directly in 5b799d4 . But apparently we do not even run tests anymore with travis, eh... need to prep github workflow and see in general if all kosher first

a-detiste · 2023-11-09T14:50:18Z

pyflakes told me that time & stat where used somewhere without being defined, I included a fix for these in the PR

yarikoptic · 2023-11-09T16:35:04Z

I have moved testing over to github in #187, please rebase.

yarikoptic · 2023-11-09T16:36:50Z

if want to go "wilder" , might even consider using pyupgrade. E.g. see "fresh example" in dandi/dandi-cli#1350 . It is ok IMHO to drop EOL'ed python versions while at it ;)

yarikoptic · 2023-11-09T16:47:30Z

thanks for the rebase! If you get a chance and could rewrite that commit to get commit message describing the change in it (title of this PR?), not action how it came about ("rebase") -- would be appreciated!

codecov-commenter · 2023-11-09T16:47:45Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d2e36ef) 82.06% compared to head (cb8b82b) 82.35%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   82.06%   82.35%   +0.28%     
==========================================
  Files          47       47              
  Lines        2437     2420      -17     
  Branches      344      339       -5     
==========================================
- Hits         2000     1993       -7     
+ Misses        362      356       -6     
+ Partials       75       71       -4

Flag	Coverage Δ
unittests	`82.23% <93.75%> (+0.28%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
duecredit/cmdline/helpers.py	`44.82% <100.00%> (ø)`
duecredit/dueswitch.py	`78.46% <100.00%> (ø)`
duecredit/entries.py	`91.83% <100.00%> (+3.37%)`	⬆️
duecredit/injections/injector.py	`79.51% <100.00%> (-0.10%)`	⬇️
duecredit/io.py	`82.55% <100.00%> (+1.18%)`	⬆️
duecredit/log.py	`54.00% <100.00%> (ø)`
duecredit/parsers.py	`0.00% <ø> (ø)`
duecredit/stub.py	`72.00% <100.00%> (ø)`
duecredit/tests/mod/imported.py	`100.00% <100.00%> (ø)`
duecredit/tests/test__main__.py	`100.00% <100.00%> (ø)`
... and 12 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

a-detiste · 2023-11-09T17:19:55Z

running a plain pytest fail the same here...

yarikoptic · 2023-11-11T04:06:20Z

odd that github didn't run any tests now here :-/ running locally there is a bunch of unrelated warnings (will address them separately) but tests pass

❯ git describe
0.9.2-12-gca2ab95
❯ python -m pytest -s -v .
====================================================================================== test session starts =======================================================================================
platform linux -- Python 3.11.6, pytest-7.4.3, pluggy-1.3.0 -- /home/yoh/proj/duecredit/venvs/dev3.11/bin/python
cachedir: .pytest_cache
rootdir: /home/yoh/proj/duecredit
configfile: tox.ini
plugins: cov-4.1.0
collected 76 items                                                                                                                                                                               

duecredit/tests/test__main__.py::test_main_help PASSED
duecredit/tests/test__main__.py::test_main_version PASSED
duecredit/tests/test__main__.py::test_main_run_a_script PASSED
duecredit/tests/test_api.py::test_api[DueCreditCollector] PASSED
duecredit/tests/test_api.py::test_api[InactiveDueCreditCollector] PASSED
duecredit/tests/test_api.py::test_noincorrect_import_if_no_lxml PASSED
duecredit/tests/test_api.py::test_noincorrect_import_if_no_lxml_numpy[kwargs0-env0] SKIPPED (We need to have numpy to test correct operation)
duecredit/tests/test_api.py::test_noincorrect_import_if_no_lxml_numpy[kwargs0-env1] SKIPPED (We need to have numpy to test correct operation)
duecredit/tests/test_api.py::test_noincorrect_import_if_no_lxml_numpy[kwargs0-env2] SKIPPED (We need to have numpy to test correct operation)
duecredit/tests/test_api.py::test_noincorrect_import_if_no_lxml_numpy[kwargs0-env3] SKIPPED (We need to have numpy to test correct operation)
duecredit/tests/test_api.py::test_noincorrect_import_if_no_lxml_numpy[kwargs1-env0] SKIPPED (We need to have numpy to test correct operation)
duecredit/tests/test_api.py::test_noincorrect_import_if_no_lxml_numpy[kwargs1-env1] SKIPPED (We need to have numpy to test correct operation)
duecredit/tests/test_api.py::test_noincorrect_import_if_no_lxml_numpy[kwargs1-env2] SKIPPED (We need to have numpy to test correct operation)
duecredit/tests/test_api.py::test_noincorrect_import_if_no_lxml_numpy[kwargs1-env3] SKIPPED (We need to have numpy to test correct operation)
duecredit/tests/test_cmdline.py::test_import PASSED
duecredit/tests/test_cmdline.py::test_main_help PASSED
duecredit/tests/test_cmdline.py::test_main_version PASSED
duecredit/tests/test_cmdline.py::test_smoke_cmd_summary PASSED
duecredit/tests/test_cmdline.py::test_cmd_test 2023-11-10 23:04:00,996 [ERROR  ] Just use pytest duecredit for now (NotImplementedError) (main.py:179)
PASSED
duecredit/tests/test_collector.py::test_citation_paths PASSED
duecredit/tests/test_collector.py::test_entry PASSED
duecredit/tests/test_collector.py::test_dcite_method PASSED
duecredit/tests/test_collector.py::test_args_match_conditions PASSED
duecredit/tests/test_collector.py::test_dcite_match_conditions_function PASSED
duecredit/tests/test_collector.py::test_dcite_match_conditions_method PASSED
duecredit/tests/test_collector.py::test_get_output_handler_method PASSED
duecredit/tests/test_collector.py::test_collectors_uniform_api PASSED
duecredit/tests/test_collector.py::test__docs__ PASSED
duecredit/tests/test_dueswitch.py::test_dueswitch_activate PASSED
duecredit/tests/test_dueswitch.py::test_a_bad_one PASSED
duecredit/tests/test_entries.py::test_comparison PASSED
duecredit/tests/test_entries.py::test_sugaring_api PASSED
duecredit/tests/test_injections.py::TestActiveInjector::test_simple_injection[testfunc1-from duecredit.tests.mod import testfunc1-None] PASSED
duecredit/tests/test_injections.py::TestActiveInjector::test_simple_injection[TestClass1.testmeth1-from duecredit.tests.mod import TestClass1; c = TestClass1()-c.testmeth1] PASSED
duecredit/tests/test_injections.py::TestActiveInjector::test_simple_injection[TestClass12.Embed.testmeth1-from duecredit.tests.mod import TestClass12; c = TestClass12.Embed()-c.testmeth1] PASSED
duecredit/tests/test_injections.py::TestActiveInjector::test_double_injection[testfunc1-from duecredit.tests.mod import testfunc1-None] PASSED
duecredit/tests/test_injections.py::TestActiveInjector::test_double_injection[TestClass1.testmeth1-from duecredit.tests.mod import TestClass1; c = TestClass1()-c.testmeth1] PASSED
duecredit/tests/test_injections.py::TestActiveInjector::test_double_injection[TestClass12.Embed.testmeth1-from duecredit.tests.mod import TestClass12; c = TestClass12.Embed()-c.testmeth1] PASSED
duecredit/tests/test_injections.py::TestActiveInjector::test_delayed_entries SKIPPED (scipy was not found: No module named 'scipy')
duecredit/tests/test_injections.py::TestActiveInjector::test_import_mvpa2_suite SKIPPED (no mvpa2 found)
duecredit/tests/test_injections.py::TestActiveInjector::test_incorrect_path[nonexistingmodule-None] PASSED
duecredit/tests/test_injections.py::TestActiveInjector::test_incorrect_path[duecredit.tests.mod.nonexistingmodule-None] PASSED
duecredit/tests/test_injections.py::TestActiveInjector::test_incorrect_path[duecredit.tests.mod-nonexisting] 2023-11-10 23:04:01,009 [WARNING] Could not find nonexisting in module <module 'duecredit.tests.mod' from '/home/yoh/proj/duecredit/duecredit/tests/mod/__init__.py'>: module 'duecredit.tests.mod' has no attribute 'nonexisting' (injector.py:206)
PASSED
duecredit/tests/test_injections.py::TestActiveInjector::test_incorrect_path[duecredit.tests.mod-nonexisting.whocares] 2023-11-10 23:04:01,010 [WARNING] Could not find nonexisting.whocares in module <module 'duecredit.tests.mod' from '/home/yoh/proj/duecredit/duecredit/tests/mod/__init__.py'>: module 'duecredit.tests.mod' has no attribute 'nonexisting' (injector.py:206)
PASSED
duecredit/tests/test_injections.py::test_find_iobject PASSED
duecredit/tests/test_injections.py::test_no_double_activation 2023-11-10 23:04:01,010 [WARNING] Seems that we are calling duecredit_importer twice. No harm is done but shouldn't happen (injector.py:309)
PASSED
duecredit/tests/test_injections.py::test_get_modules_for_injection PASSED
duecredit/tests/test_injections.py::test_cover_our_injections PASSED
duecredit/tests/test_injections.py::test_no_harm_from_deactivate 2023-11-10 23:04:01,013 [WARNING] _orig_import is not yet known, so we haven't decorated default importer yet. Nothing TODO (injector.py:359)
PASSED
duecredit/tests/test_injections.py::test_injector_del PASSED
duecredit/tests/test_injections.py::test_injector_delayed_del PASSED
duecredit/tests/test_io.py::test_import_doi 2023-11-10 23:04:01,245 [WARNING] Failed to obtain bibtex from doi.org, retrying... (io.py:64)
2023-11-10 23:04:01,449 [WARNING] Failed to obtain bibtex from doi.org, retrying... (io.py:64)
PASSED
duecredit/tests/test_io.py::test_pickleoutput PASSED
duecredit/tests/test_io.py::test_output PASSED
duecredit/tests/test_io.py::test_output_return_all PASSED
duecredit/tests/test_io.py::test_output_tags PASSED
duecredit/tests/test_io.py::test_text_output PASSED
duecredit/tests/test_io.py::test_text_output_dump_formatting PASSED
duecredit/tests/test_io.py::test_bibtex_output PASSED
duecredit/tests/test_io.py::test_get_text_rendering PASSED
duecredit/tests/test_io.py::test_text_text_rendering PASSED
duecredit/tests/test_io.py::test_url_text_rendering PASSED
duecredit/tests/test_io.py::test_format_bibtex_zenodo_doi PASSED
duecredit/tests/test_io.py::test_format_bibtex_with_utf_characters PASSED
duecredit/tests/test_io.py::test_is_contained PASSED
duecredit/tests/test_utils.py::test_is_interactive_crippled_stdout 2023-11-10 23:04:01,501 [WARNING] Assuming non interactive session since isatty found missing (utils.py:45)
2023-11-10 23:04:01,501 [WARNING] Assuming non interactive session since isatty found missing (utils.py:45)
2023-11-10 23:04:01,501 [WARNING] Assuming non interactive session since isatty found missing (utils.py:45)
PASSED
duecredit/tests/test_versions.py::test_external_versions_basic PASSED
duecredit/tests/test_versions.py::test_external_versions_unknown PASSED
duecredit/tests/test_versions.py::test_external_versions_popular_packages[scipy] SKIPPED (could not import 'scipy': No module named 'scipy')
duecredit/tests/test_versions.py::test_external_versions_popular_packages[numpy] SKIPPED (could not import 'numpy': No module named 'numpy')
duecredit/tests/test_versions.py::test_external_versions_popular_packages[mvpa2] SKIPPED (could not import 'mvpa2': No module named 'mvpa2')
duecredit/tests/test_versions.py::test_external_versions_popular_packages[sklearn] SKIPPED (could not import 'sklearn': No module named 'sklearn')
duecredit/tests/test_versions.py::test_external_versions_popular_packages[statsmodels] SKIPPED (could not import 'statsmodels': No module named 'statsmodels')
duecredit/tests/test_versions.py::test_external_versions_popular_packages[pandas] SKIPPED (could not import 'pandas': No module named 'pandas')
duecredit/tests/test_versions.py::test_external_versions_popular_packages[matplotlib] SKIPPED (could not import 'matplotlib': No module named 'matplotlib')
duecredit/tests/test_versions.py::test_external_versions_popular_packages[psychopy] SKIPPED (could not import 'psychopy': No module named 'psychopy')

======================================================================================== warnings summary ========================================================================================
duecredit/tests/test_api.py::test_api[DueCreditCollector]
duecredit/tests/test_versions.py::test_external_versions_basic
  /home/yoh/proj/duecredit/duecredit/versions.py:80: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
    return LooseVersion(version)

duecredit/tests/test_injections.py::TestActiveInjector::test_simple_injection[testfunc1-from duecredit.tests.mod import testfunc1-None]
duecredit/tests/test_injections.py::TestActiveInjector::test_simple_injection[TestClass1.testmeth1-from duecredit.tests.mod import TestClass1; c = TestClass1()-c.testmeth1]
duecredit/tests/test_injections.py::TestActiveInjector::test_simple_injection[TestClass12.Embed.testmeth1-from duecredit.tests.mod import TestClass12; c = TestClass12.Embed()-c.testmeth1]
duecredit/tests/test_versions.py::test_external_versions_basic
duecredit/tests/test_versions.py::test_external_versions_basic
duecredit/tests/test_versions.py::test_external_versions_basic
duecredit/tests/test_versions.py::test_external_versions_basic
  /home/yoh/proj/duecredit/venvs/dev3.11/lib/python3.11/site-packages/setuptools/_distutils/version.py:345: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
    other = LooseVersion(other)

duecredit/tests/test_injections.py::TestActiveInjector::test_simple_injection[testfunc1-from duecredit.tests.mod import testfunc1-None]
  /home/yoh/proj/duecredit/venvs/dev3.11/lib/python3.11/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
  duecredit/tests/test_injections.py::TestActiveInjector::test_simple_injection[testfunc1-from duecredit.tests.mod import testfunc1-None] is using nose-specific method: `teardown(self)`
  To remove this warning, rename it to `teardown_method(self)`
  See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
    next(it)

duecredit/tests/test_injections.py::TestActiveInjector::test_simple_injection[TestClass1.testmeth1-from duecredit.tests.mod import TestClass1; c = TestClass1()-c.testmeth1]
  /home/yoh/proj/duecredit/venvs/dev3.11/lib/python3.11/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
  duecredit/tests/test_injections.py::TestActiveInjector::test_simple_injection[TestClass1.testmeth1-from duecredit.tests.mod import TestClass1; c = TestClass1()-c.testmeth1] is using nose-specific method: `teardown(self)`
  To remove this warning, rename it to `teardown_method(self)`
  See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
    next(it)

duecredit/tests/test_injections.py::TestActiveInjector::test_simple_injection[TestClass12.Embed.testmeth1-from duecredit.tests.mod import TestClass12; c = TestClass12.Embed()-c.testmeth1]
  /home/yoh/proj/duecredit/venvs/dev3.11/lib/python3.11/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
  duecredit/tests/test_injections.py::TestActiveInjector::test_simple_injection[TestClass12.Embed.testmeth1-from duecredit.tests.mod import TestClass12; c = TestClass12.Embed()-c.testmeth1] is using nose-specific method: `teardown(self)`
  To remove this warning, rename it to `teardown_method(self)`
  See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
    next(it)

duecredit/tests/test_injections.py::TestActiveInjector::test_double_injection[testfunc1-from duecredit.tests.mod import testfunc1-None]
  /home/yoh/proj/duecredit/venvs/dev3.11/lib/python3.11/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
  duecredit/tests/test_injections.py::TestActiveInjector::test_double_injection[testfunc1-from duecredit.tests.mod import testfunc1-None] is using nose-specific method: `teardown(self)`
  To remove this warning, rename it to `teardown_method(self)`
  See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
    next(it)

duecredit/tests/test_injections.py::TestActiveInjector::test_double_injection[TestClass1.testmeth1-from duecredit.tests.mod import TestClass1; c = TestClass1()-c.testmeth1]
  /home/yoh/proj/duecredit/venvs/dev3.11/lib/python3.11/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
  duecredit/tests/test_injections.py::TestActiveInjector::test_double_injection[TestClass1.testmeth1-from duecredit.tests.mod import TestClass1; c = TestClass1()-c.testmeth1] is using nose-specific method: `teardown(self)`
  To remove this warning, rename it to `teardown_method(self)`
  See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
    next(it)

duecredit/tests/test_injections.py::TestActiveInjector::test_double_injection[TestClass12.Embed.testmeth1-from duecredit.tests.mod import TestClass12; c = TestClass12.Embed()-c.testmeth1]
  /home/yoh/proj/duecredit/venvs/dev3.11/lib/python3.11/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
  duecredit/tests/test_injections.py::TestActiveInjector::test_double_injection[TestClass12.Embed.testmeth1-from duecredit.tests.mod import TestClass12; c = TestClass12.Embed()-c.testmeth1] is using nose-specific method: `teardown(self)`
  To remove this warning, rename it to `teardown_method(self)`
  See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
    next(it)

duecredit/tests/test_injections.py::TestActiveInjector::test_delayed_entries
  /home/yoh/proj/duecredit/venvs/dev3.11/lib/python3.11/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
  duecredit/tests/test_injections.py::TestActiveInjector::test_delayed_entries is using nose-specific method: `teardown(self)`
  To remove this warning, rename it to `teardown_method(self)`
  See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
    next(it)

duecredit/tests/test_injections.py::TestActiveInjector::test_import_mvpa2_suite
  /home/yoh/proj/duecredit/venvs/dev3.11/lib/python3.11/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
  duecredit/tests/test_injections.py::TestActiveInjector::test_import_mvpa2_suite is using nose-specific method: `teardown(self)`
  To remove this warning, rename it to `teardown_method(self)`
  See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
    next(it)

duecredit/tests/test_injections.py::TestActiveInjector::test_incorrect_path[nonexistingmodule-None]
  /home/yoh/proj/duecredit/venvs/dev3.11/lib/python3.11/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
  duecredit/tests/test_injections.py::TestActiveInjector::test_incorrect_path[nonexistingmodule-None] is using nose-specific method: `teardown(self)`
  To remove this warning, rename it to `teardown_method(self)`
  See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
    next(it)

duecredit/tests/test_injections.py::TestActiveInjector::test_incorrect_path[duecredit.tests.mod.nonexistingmodule-None]
  /home/yoh/proj/duecredit/venvs/dev3.11/lib/python3.11/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
  duecredit/tests/test_injections.py::TestActiveInjector::test_incorrect_path[duecredit.tests.mod.nonexistingmodule-None] is using nose-specific method: `teardown(self)`
  To remove this warning, rename it to `teardown_method(self)`
  See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
    next(it)

duecredit/tests/test_injections.py::TestActiveInjector::test_incorrect_path[duecredit.tests.mod-nonexisting]
  /home/yoh/proj/duecredit/venvs/dev3.11/lib/python3.11/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
  duecredit/tests/test_injections.py::TestActiveInjector::test_incorrect_path[duecredit.tests.mod-nonexisting] is using nose-specific method: `teardown(self)`
  To remove this warning, rename it to `teardown_method(self)`
  See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
    next(it)

duecredit/tests/test_injections.py::TestActiveInjector::test_incorrect_path[duecredit.tests.mod-nonexisting.whocares]
  /home/yoh/proj/duecredit/venvs/dev3.11/lib/python3.11/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
  duecredit/tests/test_injections.py::TestActiveInjector::test_incorrect_path[duecredit.tests.mod-nonexisting.whocares] is using nose-specific method: `teardown(self)`
  To remove this warning, rename it to `teardown_method(self)`
  See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
    next(it)

duecredit/tests/test_versions.py::test_external_versions_basic
  /home/yoh/proj/duecredit/duecredit/versions.py:77: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
    return StrictVersion(version)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
====================================================================================== slowest 10 durations ======================================================================================
0.43s call     duecredit/tests/test_io.py::test_import_doi
0.08s call     duecredit/tests/test_api.py::test_noincorrect_import_if_no_lxml
0.02s call     duecredit/tests/test_io.py::test_text_output
0.02s call     duecredit/tests/test_io.py::test_text_output_dump_formatting
0.01s call     duecredit/tests/test_injections.py::test_injector_del
0.01s call     duecredit/tests/test_injections.py::test_injector_delayed_del

(4 durations < 0.005s hidden.  Use -vv to show these durations.)
========================================================================== 58 passed, 18 skipped, 22 warnings in 0.65s ===========================================================================
 ~/proj/duecredit  no-six:master *7 ?1 ▓▒░──────────────────────────────────────────────────────────────────────────────────────────────────────────

yarikoptic · 2023-11-11T20:49:03Z

FWIW, merged #190 so there should be less whining from pytest happen you rebase again and we get tests running this time. Let me also invite you to become part of the project so hopefully tests just run for your PRs.

yarikoptic · 2023-11-12T15:56:07Z

yeay -- it is green. Lets release!

a-detiste · 2023-11-12T18:51:59Z

Sorry, sorry, sorry, I messed up my remotes in git & push to the wrong repository.

The plan was to create a PR to discuss it.

yarikoptic · 2023-11-12T19:02:43Z

thanks for the buzz! for it to be "clean" I just reset to the released version, so your commits are gone now -- you are welcome now to send a PR with them. Recommendation in general to adopt practice of feature branches -- never work directly on "master", and you will have harder time to mess up ;)

a-detiste changed the title ~~remove remaining usage of SIX~~ RF: remove remaining usage of SIX Nov 9, 2023

a-detiste force-pushed the master branch from ad53ba6 to bcd0b3c Compare November 9, 2023 14:43

a-detiste force-pushed the master branch from bcd0b3c to 5cb3a65 Compare November 9, 2023 16:44

RF: remove dependency on SIX

ca2ab95

a-detiste force-pushed the master branch from 5cb3a65 to ca2ab95 Compare November 9, 2023 16:52

Use teardown_method instead of nose-y teardown

cb8b82b

yarikoptic changed the title ~~RF: remove remaining usage of SIX~~ RF: remove remaining usage of SIX, and thus move away fully from Python 2 Nov 12, 2023

yarikoptic added release Create a release when this pr is merged internal Changes only affect the internal API labels Nov 12, 2023

yarikoptic merged commit 581bce8 into duecredit:master Nov 12, 2023
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RF: remove remaining usage of SIX, and thus move away fully from Python 2 #186

RF: remove remaining usage of SIX, and thus move away fully from Python 2 #186

a-detiste commented Nov 9, 2023

yarikoptic commented Nov 9, 2023

a-detiste commented Nov 9, 2023

yarikoptic commented Nov 9, 2023

yarikoptic commented Nov 9, 2023

yarikoptic commented Nov 9, 2023

codecov-commenter commented Nov 9, 2023 •

edited

a-detiste commented Nov 9, 2023

yarikoptic commented Nov 11, 2023

yarikoptic commented Nov 11, 2023

yarikoptic commented Nov 12, 2023

a-detiste commented Nov 12, 2023

yarikoptic commented Nov 12, 2023

RF: remove remaining usage of SIX, and thus move away fully from Python 2 #186

RF: remove remaining usage of SIX, and thus move away fully from Python 2 #186

Conversation

a-detiste commented Nov 9, 2023

Changes

yarikoptic commented Nov 9, 2023

a-detiste commented Nov 9, 2023

yarikoptic commented Nov 9, 2023

yarikoptic commented Nov 9, 2023

yarikoptic commented Nov 9, 2023

codecov-commenter commented Nov 9, 2023 • edited

Codecov Report

a-detiste commented Nov 9, 2023

yarikoptic commented Nov 11, 2023

yarikoptic commented Nov 11, 2023

yarikoptic commented Nov 12, 2023

a-detiste commented Nov 12, 2023

yarikoptic commented Nov 12, 2023

codecov-commenter commented Nov 9, 2023 •

edited