Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from Travis to github workflow, disable coveralls #187

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Conversation

yarikoptic
Copy link
Member

workflow is based on dandi-cli one

@yarikoptic yarikoptic added the tests Add or improve existing tests label Nov 9, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0345105) 83.29% compared to head (e7cd732) 81.25%.
Report is 8 commits behind head on master.

❗ Current head e7cd732 differs from pull request most recent head d2ee0ce. Consider uploading reports for the commit d2ee0ce to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   83.29%   81.25%   -2.05%     
==========================================
  Files          47       46       -1     
  Lines        2437     2432       -5     
  Branches      259      259              
==========================================
- Hits         2030     1976      -54     
- Misses        332      379      +47     
- Partials       75       77       +2     
Flag Coverage Δ
unittests 81.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
duecredit/collector.py 71.75% <ø> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-detiste
Copy link
Contributor

To further improve this package I would test it with mypy (I can add annotations in an other PR)

@yarikoptic yarikoptic merged commit d2e36ef into master Nov 9, 2023
13 checks passed
@yarikoptic
Copy link
Member Author

To further improve this package I would test it with mypy (I can add annotations in an other PR)

I do not think we have any type annotation ATM here. Contributions are of cause welcome and thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants