Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to be able to filter ADS or (!INSPIRE). #8

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

duetosymmetry
Copy link
Owner

This adds a cli option and the python code which enables it. Currently there are only two filter types available:

  • "ads" which is the old behavior
  • "all" which is all bibkeys that do not look like INSPIRE keys
    I imagine others might want to implement their own filter types, or we can allow regexes on the commandline. The latter would require again changing the cli behavior, because we would want another string input aside from the Choice "regex" or similar.

@matthewfeickert matthewfeickert added enhancement New feature or request API Affects the public API labels Jul 8, 2020
@matthewfeickert
Copy link
Collaborator

I'm going to rebase this against master real quick so that it doesn't have a repeat commit.

Copy link
Collaborator

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code wise, though maybe worth adding an example of the new CLI feature to the README? I'll approve this though as the code seems fine.

@duetosymmetry
Copy link
Owner Author

Sorry about the double commit! I forgot to back up to master before checking out a new feature branch. Good idea about the extra documentation.

@matthewfeickert
Copy link
Collaborator

Sorry about the double commit! I forgot to back up to master before checking out a new feature branch.

Oh no, nothing to be sorry about! We do this all the time on pyhf, but we just are in the habit of rebasing our feature branches off of the current state of master.

@duetosymmetry duetosymmetry merged commit 8a822d5 into master Jul 8, 2020
@duetosymmetry duetosymmetry deleted the feature/filter-type branch July 8, 2020 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Affects the public API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants