Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some edge cases in preprocess logic #3

Merged
merged 5 commits into from
Apr 6, 2018

Conversation

platinumazure
Copy link
Contributor

Added some new failing tests and fixed the code to ensure the tests pass. I also created a fixture directory to make it easier to add new cases.

Copy link
Owner

@duhaime duhaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@platinumazure Thanks so much for this! My only question is why not call the mocha binary right from the node_modules? I prefer to avoid globally installing modules, so would rather revert to ./node_modules/mocha/bin/mocha ./tests/*.js in package.json. This reversion would also help others who prefer to avoid dependency installation at the system level. What do you think about that?

@platinumazure
Copy link
Contributor Author

platinumazure commented Apr 6, 2018 via email

@platinumazure
Copy link
Contributor Author

See https://yarnpkg.com/lang/en/docs/cli/run/ for more details.

@duhaime
Copy link
Owner

duhaime commented Apr 6, 2018

Ah, thanks @platinumazure I didn't know that! Thanks again for this PR!

@duhaime duhaime merged commit e42eba6 into duhaime:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants