Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve list rendering performance #246

Closed
tmfrnz opened this issue Jun 22, 2017 · 4 comments
Closed

Improve list rendering performance #246

tmfrnz opened this issue Jun 22, 2017 · 4 comments
Assignees
@tmfrnz
Milestone
1

Comments

@tmfrnz
Copy link
Member

tmfrnz commented Jun 22, 2017

Whole list is unnecessarily re-rendered, especially

  • when sidebar panels open
  • when link is clicked to leave page
@tmfrnz tmfrnz self-assigned this Jun 22, 2017
@tmfrnz tmfrnz mentioned this issue Jun 22, 2017
Closed
tmfrnz added a commit that referenced this issue Jun 25, 2017
@tmfrnz
add pagination and implement shouldComponentUpdate #246
3a66bc1
@tmfrnz
Copy link
Member Author

tmfrnz commented Jun 26, 2017

introduced pagination to mitigate performance issues

tmfrnz added a commit that referenced this issue Jun 26, 2017
@tmfrnz
Merge pull request #250 from dumparkltd/performance-246
eb0acf4 
Performancepagination, shouldComponentUpdate #246
@tmfrnz
Copy link
Member Author

tmfrnz commented Jun 27, 2017

consider using https://github.com/bvaughn/react-virtualized to only render the visible rows

@tmfrnz tmfrnz added review and removed in progress labels Jul 4, 2017
@tmfrnz
Copy link
Member Author

tmfrnz commented Jul 4, 2017

for rendering only visible list items instead of https://github.com/bvaughn/react-virtualized introduced a combination of https://github.com/stutrek/scrollmonitor-react and https://github.com/planttheidea/react-rendered-size

@tmfrnz
Copy link
Member Author

tmfrnz commented Jul 4, 2017

introduced list specific selectors for memoisation and less re-rerenders

tmfrnz added a commit that referenced this issue Jul 5, 2017
@tmfrnz
Merge pull request #252 from dumparkltd/performance-246
4aeccc2 
Performance #246
@tmfrnz tmfrnz closed this as completed Jul 20, 2017
@tmfrnz tmfrnz removed the review label Jul 20, 2017
tmfrnz added a commit that referenced this issue Jul 27, 2017
@tmfrnz
only pass wrapper when not rendering virtually #27, #246
08e8c9a
@tmfrnz tmfrnz modified the milestone: Version 1 Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmfrnz tmfrnz

Labels
None yet
Projects
None yet
Milestone
1
Development

No branches or pull requests
1 participant
@tmfrnz