Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Statamic 5 #1039

Merged
merged 29 commits into from
Apr 13, 2024
Merged

[7.x] Statamic 5 #1039

merged 29 commits into from
Apr 13, 2024

Conversation

duncanmcclean
Copy link
Owner

@duncanmcclean duncanmcclean commented Apr 4, 2024

This pull request makes the necessary changes required to support Statamic 5.

This PR will be added to as time goes on.

Changes

  • Updates the version constraint in composer.json
    • Changed to dev-master for now. Once v5 has been released, it can be changed to ^5.0.
  • Adjusted testing matrix
  • Replaces laravel/helpers functions
    • Statamic 5 dropped the laravel/helpers dependency, which provided backwards compatibility for old string/array helpers.
    • We were using some of the helpers provided by this package, so I've replaced them with calls to Laravel's Str class.
  • Simplifies the TestCase
  • Fixed broken Ignition solutions.
  • Changed how we call the Antlers parser in SendConfiguredNotifications
    • Previously, we were directly calling the Regex parser. However, the Regex Parser has been removed in Statamic 5 so this updates the code to call Antlers::parser() instead.
  • Changed how we get a database table's columns
    • Laravel 11 removed its doctrine/dbal dependency but it provided alternative methods for everything it was providing, so we've adjusted our code to use it.

To Do

  • Investigate failing order notification tests
  • Adjust version constraints in composer.json & testing matrix to released versions, rather than dev-* versions.

@duncanmcclean duncanmcclean changed the base branch from 6.x to main April 6, 2024 16:53
@duncanmcclean duncanmcclean marked this pull request as ready for review April 13, 2024 08:20
@duncanmcclean duncanmcclean merged commit 32b7ec4 into main Apr 13, 2024
10 checks passed
@duncanmcclean duncanmcclean deleted the statamic-5 branch April 13, 2024 08:20
Copy link

github-actions bot commented May 9, 2024

Released as part of v7.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant