Ability to customise currency symbols #850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes it possible to customise the currency formatting symbols.
Under the hood, Simple Commerce uses PHP's built-in
NumberFormatter
to take numbers and format them. However, there are some cases where the formatted output it produces isn't correct for some currencies.This PR adds two config options allowing you to customise two of the currency formatting separators.
It's worth noting that this PR won't change the currency format used in the Money fieldtype in the Control Panel - I don't have time to implement that right now. However, I would accept a pull request if someone needs it.
Example
Normally: £1,234.56
With the above config settings, that number turns into £1.234,56.