warn user when short-circuiting initialisation #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Debian bug report and discussion here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=989679 The bug submitter suggests using a mechanism like the following to prevent test failures when Tk isn't present: https://github.com/dod38fr/config-model-tk-ui/blob/5cf873739ea40771bd39226c7cbfc23b0fdc2ff4/t/config-model-ui.t#L96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to give the user some indication as to why ClusterSSH fails to start when either
AUTHOR_TESTINGorRELEASE_TESTINGare present in the environment.See the Debian bug report for Debian-Bug 989679 for a brief discussion.
The bug submitter suggests using a mechanism like the following to
prevent test failures when Tk isn't present:
https://github.com/dod38fr/config-model-tk-ui/blob/5cf873739ea40771bd39226c7cbfc23b0fdc2ff4/t/config-model-ui.t#L96