Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] ocamlfind and findlib (1.9.5+dune) #173

Merged

Conversation

emillon
Copy link
Contributor

@emillon emillon commented Aug 2, 2022

A library manager for OCaml

CHANGES:

@gridbugs
Copy link
Contributor

I'm getting errors when I try to vendor ocamlfind and I think this PR will solve my problem. What's required for this to be merged?

For the record, my error is:

$ dune exec ocamlfind
Entering directory '/Users/s/src/vendor-ocamlfind'
File "duniverse/lib-findlib/src/findlib/fl_metascanner.ml", line 41, characters 13-25:
41 |           in Stream.lsing (fun _ -> (line, pos, Eof))
                  ^^^^^^^^^^^^
Error: Unbound module Stream
File "duniverse/lib-findlib/src/findlib/fl_package_base.ml", line 157, characters 6-18:
157 |     | Stream.Error s ->
            ^^^^^^^^^^^^
Error: Unbound module Stream
File "duniverse/lib-findlib/src/findlib/frontend.ml", line 1826, characters 16-29:
1826 |       let buf = String.create buflen in   (* FIXME: Bytes.create *)
                       ^^^^^^^^^^^^^
Error: Unbound value String.create

@Leonidas-from-XIV
Copy link
Contributor

Merging as the only failure seems to be an (possibly invalid) linter failure. And from here it will be easier to support OCaml 5.0.0.

@Leonidas-from-XIV Leonidas-from-XIV merged commit 3244955 into dune-universe:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants