Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing JSON rule that was present in previous tutorials. #39

Merged
merged 6 commits into from
Apr 20, 2018

Conversation

studersi
Copy link
Contributor

@studersi studersi commented Apr 3, 2018

No description provided.

@dune73
Copy link
Owner

dune73 commented Apr 3, 2018

I need to check this across all tutorials. Keeping this open for the time being.

@dune73
Copy link
Owner

dune73 commented Apr 5, 2018

Tutorial-9 is equally affected by this problem. Could you cover that with your PR as well, please?

@studersi
Copy link
Contributor Author

studersi commented Apr 5, 2018

Done.

@dune73
Copy link
Owner

dune73 commented Apr 5, 2018

Thank you. But does it really work?

@studersi
Copy link
Contributor Author

Just tested and indeed there was a problem. There were duplicate IDs. It's fixed now. I also ran some request which seemed to work just fine.

@dune73
Copy link
Owner

dune73 commented Apr 20, 2018

Correct. Thank you for the fix.

@dune73 dune73 merged commit aaf7aa1 into dune73:master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants