Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bonkbot): only include unique fee payment tx's to prevent dupes #6189

Merged
merged 9 commits into from
Jun 21, 2024

Conversation

whalehunting
Copy link
Contributor

Fix regarding #6176 - thanks for pinging me @jeff-dude !

From now on no duplicates should be included in the spellbook

@dune-eng
Copy link

Workflow run id 9550377854 approved.

@dune-eng
Copy link

Workflow run id 9550378240 approved.

@dune-eng
Copy link

Workflow run id 9550713670 approved.

@dune-eng
Copy link

Workflow run id 9550714158 approved.

@jeff-dude jeff-dude self-assigned this Jun 17, 2024
@jeff-dude jeff-dude added the WIP work in progress label Jun 17, 2024
@dune-eng
Copy link

Workflow run id 9567932996 approved.

@dune-eng
Copy link

Workflow run id 9567933298 approved.

@dune-eng
Copy link

Workflow run id 9570308574 approved.

@dune-eng
Copy link

Workflow run id 9570308593 approved.

@dune-eng
Copy link

Workflow run id 9570309853 approved.

@dune-eng
Copy link

Workflow run id 9570310180 approved.

@jeff-dude jeff-dude assigned 0xRobin and unassigned jeff-dude Jun 19, 2024
@jeff-dude
Copy link
Member

hey @0xRobin -- as discussed, can you help support this open PR for solana bot trades? we had to exclude this one on dupes. this PR is intended to fix that. i'll be out rest of week, so would be nice if you could help as needed 🙏

@jeff-dude
Copy link
Member

we're hitting that odd error here that has been occurring across PRs. @aalan3 is actively talking to our platform team to find out why

@whalehunting
Copy link
Contributor Author

could we just merge it into production and check if the duplication error still exists? if so, we could revert it by adding the prod_exclude tag to the schema config again

@0xRobin @aalan3 thx for helping out btw, really appreciate it!

@whalehunting
Copy link
Contributor Author

nice, it worked! seed is expected to fail bc we only included data from the last few days. if you're fine with it i would revert the project_start_date to the original value and then we can get this merged @0xRobin @jeff-dude

@0xRobin
Copy link
Collaborator

0xRobin commented Jun 20, 2024

yes go for it @whalehunting

@dune-eng
Copy link

Workflow run id 9597127271 approved.

@dune-eng
Copy link

Workflow run id 9597127759 approved.

@dune-eng
Copy link

Workflow run id 9597131257 approved.

@dune-eng
Copy link

Workflow run id 9597131529 approved.

@whalehunting
Copy link
Contributor Author

@0xRobin done. it's ready to get deployed!

@0xRobin 0xRobin added ready-for-merging and removed WIP work in progress labels Jun 20, 2024
@aalan3 aalan3 merged commit add8b2c into duneanalytics:main Jun 21, 2024
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants