Fix readme #74
Merged
Fix readme #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
approved these changes
Jul 11, 2019
|
Thanks @ajgarlag! |
CvekCoding
reviewed
Jul 26, 2019
| @@ -249,9 +249,9 @@ As an example we use the Symfony `DateTimeNormalizer` service so we do have supp | |||
| ```yaml | |||
| # Add DateTime Normalizer to Dunglas' Doctrine JSON ODM Bundle | |||
| dunglas_doctrine_json_odm.serializer: | |||
| class: Symfony\Component\Serializer\Serializer | |||
There was a problem hiding this comment.
I ran into the problem with autoconfigure feature here (which is enabled by default).
In default environment dunglas_doctrine_json_odm.serializer auto-tags as normalizer. This leads to the situation when default symfony's serializer uses dunglas_doctrine_json_odm.serializer instead of objectNormalizer. As a result you cant instantiate new objects through standard symfony serializer anymore.
To solve this just use autoconfigure: false.
CvekCoding
reviewed
Jul 26, 2019
| arguments: | ||
| - ['@serializer.normalizer.datetime', '@dunglas_doctrine_json_odm.normalizer.object'] | ||
| - ['@serializer.denormalizer.array', '@serializer.normalizer.datetime', '@serializer.normalizer.object'] |
There was a problem hiding this comment.
After PR #78 we have to use
- ['@dunglas_doctrine_json_odm.normalizer.array', '@serializer.normalizer.datetime', '@dunglas_doctrine_json_odm.normalizer.object']
There was a problem hiding this comment.
@CvekCoding Include these changes in #78, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.