Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minor version as Drupal constraint #18

Closed
wants to merge 3 commits into from

Conversation

back-2-95
Copy link
Contributor

@back-2-95 back-2-95 commented Dec 11, 2023

Instead of installing a specific patch version of Drupal, install latest minor version.

Will resolve #19

# https://www.drupal.org/project/drupal/releases/10.1.2
ENV DRUPAL_VERSION 10.1.2
# https://www.drupal.org/project/drupal/releases
ENV DRUPAL_VERSION 10.1

WORKDIR /opt/drupal
# Copy from the official image when Drupal 10.0 will be released
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot we do this instead now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't remember what this refers to 😂
Not sure if Drupal releases any official Docker images.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official images are here: https://hub.docker.com/_/drupal

Something like COPY --from=drupal ---link /opt/drupal /opt/drupal should do the trick and be always up to date.

(https://github.com/docker-library/drupal/blob/master/Dockerfile.template)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check this

@@ -9,8 +9,6 @@
# Database password: example
# ADVANCED OPTIONS; Database host: postgres

version: '3.1'

services:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also rename the file compose.yaml to be in sync with be Docker best practices.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do, is there some documentation for this? This is a new thing to me.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: https://docs.docker.com/compose/compose-file/03-compose-file/

Just renaming the file should be enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, for me any docker compose command will result with no configuration file provided: not found after renaming the file. Docker Compose version v2.22.0

@dunglas
Copy link
Owner

dunglas commented Mar 29, 2024

Thank you for your contribution @back-2-95.
By the way, would you like to become co-maintainer of this repo?

@back-2-95
Copy link
Contributor Author

back-2-95 commented Apr 8, 2024

@dunglas hi, I can become co-maintainer. This is quite simple repo. That said, I'd like to set some goals:

Crystallising the purpose:

  • PoC or template for a project
  • Now it's more like PoC in a sense that it would need manual steps and changes to be used in a real project imho

Providing some quickstart for Drupal community:

  • like DDEV setup and maybe some others
  • this would help Drupal community members advance their issues regarding FrankenPHP

FYI: I don't actively code Drupal sites myself, I mostly provide tooling and devops for Drupalists for their projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Minor version for installing Drupal
2 participants