Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when a write error occurs #651

Merged
merged 3 commits into from
Mar 13, 2024
Merged

fix: crash when a write error occurs #651

merged 3 commits into from
Mar 13, 2024

Conversation

dunglas
Copy link
Owner

@dunglas dunglas commented Mar 12, 2024

SIGPIPE must be masked in the non-Go threads to prevent unexpected crashes: https://pkg.go.dev/os/signal#hdr-Go_programs_that_use_cgo_or_SWIG

Thanks @bukka for the bug report and the stack trace!

This is likely a cause (but maybe not the only one) of #557

@dunglas dunglas merged commit 71661c4 into main Mar 13, 2024
41 checks passed
@dunglas dunglas deleted the fix/SIGPIPE-crash branch March 13, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant