Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Records with implementation visibility attribute #197

Merged
merged 3 commits into from
Apr 22, 2016
Merged

Records with implementation visibility attribute #197

merged 3 commits into from
Apr 22, 2016

Conversation

OkayX6
Copy link
Contributor

@OkayX6 OkayX6 commented Apr 22, 2016 •
edited
Loading

Fixes #194

Time to fix it: ~2h (indicative - for reference).

  • Time to rebase, reunderstand the project, make a fix

@OkayX6 OkayX6 changed the title Support private record impl Support formatting of record with implementation visibility attribute Apr 22, 2016
@OkayX6 OkayX6 changed the title Support formatting of record with implementation visibility attribute Records with implementation visibility attribute Apr 22, 2016
@dungpa
Copy link
Contributor

dungpa commented Apr 22, 2016

Thanks.

Time to fix it: ~2h (indicative - for reference).

I'll buy you coffee next time :).

@dungpa dungpa merged commit 839f385 into fsprojects:master Apr 22, 2016
@OkayX6
Copy link
Contributor Author

OkayX6 commented Sep 6, 2017

I haven't had this coffee! 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatter doesn't work on Opaque Record Type
2 participants
@OkayX6 @dungpa