-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dunst does not display JPEG icons without a filename extension #540
Comments
I cannot reproduce this on debian buster. I have a feeling this is something to do with Perhaps in the version that's in stretch it only looks at the extension? I will set up a stretch VM later this week to test. |
I can't reproduce it either. And I've tested it on Xenial, trusty and bionic now.
@eadmund And to rule out a possible misbehavior[0] of dunst: How have you tested it? Have you executed any [0]: Dunst reloads the notification icon whenever it's drawing a notification complete freshly. So if you |
Looks like I get this from
I ran |
@eadmund Thanks for the answer. Sadly nothing, which enlightens me. I've written a small helper here: https://gist.github.com/bebehei/d1248deab8199ea93d877fdf126be588 Could you please clone the gist, build it and then run PS: You may need to install |
It's weird, isn't it? |
Well, that's interesting. Some things have gone south somewhere. So, the only thing, which still could help and give some clues: a logfile. Could you please run |
Here you go.
My only other guess is that the image in question is quite large (512×512). Maybe dunst (or the library it's using) doesn't know how to scale it? |
Would you bother to upload the image here!? That would be the necessary reproducer to fix it. Thanks for your reply. |
Unfortunately, it's a portrait of a friend, so I don't feel comfortable sharing it. I'll see if I can get a working test case on a similar picture. |
So, I have a working version, made by scaling http://repo.or.cz/cl-notify.git/blob/HEAD:/lisplogo_warning_128.png up with I've tried uploading the JPEG, and a zip containing the JPEG, but to no avail. |
Sorry. I can't reproduce it on ArchLinux. I'm currently building a debian stretch VM. The only thing left: Could you please paste your configuration, too!? Thanks in advance. |
I can't reproduce it either on an up to date Debian Stretch machine with the default config and dunst built from master and your given image. |
I think I can reproduce the issue.
The icon is displayed when it also works when So my guess is, the icon position is wrongly calculated and the icon is moved outside of the window. |
in draw.c:
results in
So the problem is, when dunst is configured to a fixed width and the image position is set to right aaaand |
@knopwob Wow. Thanks. Obviously a bug worth fixing! |
actually the layout is broken with I think the best solution would be to scale the image down to a reasonable size when we have a fixed width or height. |
Awesome job finding this guys, thanks much. |
It does. Thanks so much for the quick response, guys. Sounds like it was more than a little tricky to find. |
dunst
correctly displays icons from files whose names end in '.jpeg' or '.jpg,' but it does not display them when they do not.To reproduce:
Installation info
v1.3.2-143-g896c008
manually
Debian 9 (stretch)
The text was updated successfully, but these errors were encountered: