limit icon size when we have a fixed width

[knopwob]

This is a proposed fix for #540.

I'm not reallty sure/happy with this fix but it seems to be the easiest.

I'm not sure wether we should overwrite max_icon_size if it's not 0, or should we assume the user knows what he's doing?

[bebehei]

I'm not sure if this is the right place. Regarding shrink, I guess this has to get calculated more dynamically on every run. Right?

[knopwob]

Shrink will still work. The image is limited to the max_win_width/2, but when the rest of the notification is smaller than half the width it will still shrink the window. It looks rather weird but that's always the case when you have a huge image.

I agree that there are probably better solutions to this if you factor this into the drawing/icon code but
I'm not sure it is worth it to complicate that code even further.

Another way to see it is that the user created a configuration that is broken.
He wants a window that is limited to a max width but on the other hand wants to see
icons in their full size (or he set max_icon_size to a value that is unreasonably high for his max window width). So one could argue that we're just sanitizing the configuration. :D

It would be nice to have the option to resize the image to a size that's fit the rest of the notification. In other words layout the text first and derive the icon size from the resulting text size.
But I think this is a different feature.

Anyway you know the code better than me at this point so I leave the decision up to you wether you
want this fixed within the settings code or in the drawing/icon code.

[tsipinakis]

@knopwob seems to be inactive here so I took over in order to unblock 1.4.0.

Can't see a better solution so I just added some warning messages to call it a day.

[bebehei]

Could you please rebase on current master, to run through CircleCI, too?

[tsipinakis]

Done!

[genofire]

It does not work for me correct,
i run Dunst - A customizable and lightweight notification-daemon 1.4.0 (2019-03-30) with following config:

geometry             = 0x0-4+24
max_icon_size        = 32

But i get:

 WARNING: Max width was set to 0 but got a max_icon_size of 32, too large to use. Setting max_icon_size=0

Does i something wrong?

[tsipinakis]

@genofire See #614 it's a bug when dynamic width is used. It's fixed in master and I'll put out a point release once the few other bugs that were discovered after 1.4 are fixed.