Expose do_action as a keyboard shortcut #655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes the same do_action that a middle mouse click does on a notification as a keyboard shortcut. I haven't done any C in a very very long time and I have have no idea what I'm doing :) Everything was copy pasted from one of the existing keyboard shortcuts and to my surprise it just worked!
|
It looks nice, but I'm sad to turn your PR down. We're currently deprecating the X11 keybinding (#284). A replacement PR is aleady on its way: #651. Invoking Actions will be a major part. I haven't pushed those changes yet on the PR, but your feature You can expect it to be merged during the next weeks. |
|
Awesome, I'll keep an eye on that PR! |
|
Has this request merged? |
|
It hasn't yet. @bebehei Ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the same do_action that a middle mouse click does on a
notification as a keyboard shortcut.
I haven't done any C in a very very long time and I have have no idea
what I'm doing :) Everything was copy pasted from one of the existing
keyboard shortcuts and to my surprise it just worked!