report command - auditing accounts - ARN KeyError

[maestretti]

When I ran report I got a few dozen of these errors:

* Auditing accounts
WARNING:policyuniverse:ARN Could not parse [AID*******************CS].
WARNING:policyuniverse:Auditor could not parse ARN AID********************CS.

Then the report had a critical finding for audit error which detailed as:

"exception": "'Arn'",
    "traceback": "Traceback (most recent call last):\n  File \"/cloudmapper/shared/audit.py\", line 1076, in audit\n    audit_iam(findings, region)\n  File \"/cloudmapper/shared/audit.py\", line 210, in audit_iam\n    find_admins_in_account(region, findings)\n  File \"/cloudmapper/shared/iam_audit.py\", line 276, in find_admins_in_account\n    policy[\"Arn\"],\nKeyError: 'Arn'\n"

Which flags this line:

cloudmapper/shared/iam_audit.py

Line 276 in 1e60e1f

policy["Arn"],

I think the error is that the ARN is at the next level of JSON up. When policy is defined here:

cloudmapper/shared/iam_audit.py

Line 267 in 1e60e1f

for policy in role["RolePolicyList"]:

So line 276 should be role['Arn'] and I think the errors are related but not sure.

[mdavis332]

Nice, thanks @maestretti . If I change

cloudmapper/shared/iam_audit.py

Line 276 in 1e60e1f

policy["Arn"],

from policy to role

and do the same for

cloudmapper/shared/iam_audit.py

Line 458 in 1e60e1f

policy["Arn"],

Then things like find_admins start working.

[kbroughton]

I can confirm the two changes of mdavi332 fixes the find_admins error.