Issue622 Fix #640
Merged
Issue622 Fix #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
0xdabbad00
reviewed
Jan 9, 2020
|
@maestretti Are you able to sign the CLA? I know we had some issues in the past with it, but I don't know if those have been resolved yet. |
|
@0xdabbad00 I signed it... email mismatch on the commit and my GitHub account which I fixed and re-checked. Now passing checks. |
|
@0xdabbad00 this looks ready to go? |
|
Yes, thank you for following up and for submitting the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a JSON key error for #622