Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge case handling + extending of SAML providers #643

Merged
merged 2 commits into from Jan 12, 2020
Merged

Edge case handling + extending of SAML providers #643

merged 2 commits into from Jan 12, 2020

Conversation

nimrodkor
Copy link
Contributor

This PR handles a fes things:

  1. Fix null responses across prepare, weboftrust & find_unused
  2. Add 4 new SAML providers & their logos
  3. Implement SAML check with the result of list-saml-providers

0xdabbad00
0xdabbad00 reviewed Jan 12, 2020
View reviewed changes
commands/weboftrust.py
federated_principals = principal.get("Federated", None)

if federated_principals:
if not isinstance(federated_principals, list):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't considered there being multiple federated principals. Good catch.

@0xdabbad00 0xdabbad00 merged commit c2058ae into duo-labs:master Jan 12, 2020
@0xdabbad00
Copy link
Collaborator

Thank you @nimrodkor!

@0xdabbad00 0xdabbad00 mentioned this pull request Jan 14, 2020
Open
@nimrodkor nimrodkor deleted the feature/edge_case_handling branch January 14, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdabbad00 0xdabbad00 0xdabbad00 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nimrodkor @0xdabbad00