Validate use of NotResource and NotAction based on AWS best practices #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This auditor validates two AWS policy elements, and gives the user feedback to align with AWS documentation best practices.
NotResource
andNotAction
are difficult to write policies for correctly because they implicitlyAllow
access to everything that is not specified in the Statement, and then revoke access.I chose to make these 1 PR because they are both considered "advanced" policy elements by AWS and using either with
'Effect': 'Allow'
are both explicitly discouraged in the documentation. However,NotResource
is targeted towards identity-based policies, whereasNotAction
is targeted towards resource-based policies and trust relationships. So, I would be open to splitting this up somehow, e.g. by putting the checks into different community auditors Py files. Or, if we aren't ready for parliament to check resource-based policies, then we can skipNotAction
entirely.