Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate use of NotResource and NotAction based on AWS best practices #166

Merged

Conversation

raghavkaul
Copy link
Contributor

This auditor validates two AWS policy elements, and gives the user feedback to align with AWS documentation best practices. NotResource and NotAction are difficult to write policies for correctly because they implicitly Allow access to everything that is not specified in the Statement, and then revoke access.

I chose to make these 1 PR because they are both considered "advanced" policy elements by AWS and using either with 'Effect': 'Allow'are both explicitly discouraged in the documentation. However, NotResource is targeted towards identity-based policies, whereas NotAction is targeted towards resource-based policies and trust relationships. So, I would be open to splitting this up somehow, e.g. by putting the checks into different community auditors Py files. Or, if we aren't ready for parliament to check resource-based policies, then we can skip NotAction entirely.

@0xdabbad00
Copy link
Collaborator

Thank you @raghavkaul ! LGTM, this can be merged @steiza

@steiza steiza merged commit 1279c1e into duo-labs:main Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants