Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of pydantic v2>v3 deprication warning; add optional indentation #170

Closed
wants to merge 2 commits into from

Conversation

gravmatt
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2023

CLA assistant check
All committers have signed the CLA.

@MasterKale
Copy link
Collaborator

Thanks for the contribution @gravmatt, unfortunately this library is aiming to support both v1 and v2 for now so the deprecation warnings can't be addressed like this just yet. If you're interested in updating the PR to work with v1 as well I'll still accept it.

@gravmatt
Copy link
Author

gravmatt commented Sep 1, 2023

Hey @MasterKale I understand. webauthn 1.10.1 requires pydantic>=1.10.11. I installed pydantic 1.10.11 and in the helpers > options_to_json.py there is the function options_to_json which uses model_dump_json. This function was introduced in pydantic v2 and is not available in v1.

2b87a8c#diff-b58c7253734137d5c7558d6204ca581688ed2fed8559c83b28bb7741a8c98172

@MasterKale
Copy link
Collaborator

@gravmatt Thank you for creating this PR. I've decided to go with #172 because it reduces the library user's exposure to more of the v1/v2 divide. 🙇

@MasterKale MasterKale closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants