fix certain logos not showing after export

[nickgirga]

I noticed there was a warning in the editor when I was using the twist splash screen:

What it was suggesting was correct. It did not work on export (on v3.4.4.stable.official [419e713a2]).

I tested on Linux:

I tested on Android:

Neither of them showed the Godot icon because the image was not being loaded after the project was exported.

When looking for solutions, I ran across this on the internet: https://godotengine.org/qa/50031/image-fails-export-with-warning-loading-resource-image-export

This seemed to be the same problem I was experiencing. So I rewrote AweSplashScreen.load_texture(String) a bit. Instead of using image.load(path), I loaded path as a resource in a variable called stream_texture using load(path). Then, I set image to the image data from stream_texture.get_data(). This pretty much achieves the same thing, but without the warning. It also appears to work on export.

I tested on Linux:

I tested on Android:

Both show the Godot icon now.

[duongvituan]

@nickgirga
Thanks for your help :)

[nickgirga]

Of course!

If you're interested: I looked a bit more into why image.load(path) wasn't optimal for our use case and it seems that Image.load(String) loads an image directly from the image file itself (which won't be exported with the project because Godot will convert it to a stex to pack in the PCK). This may be desirable behavior, but for the vast majority of cases (and what I assume is the case here, considering we don't really need to expose the Godot logo as an image file to users and probably shouldn't), you want to use load(String) because it will actually look for that file as a stex in the exported assets after you export it instead of continuing to search for an image file that no longer exists in a standard image format. The Image.load(String) method confuses enough people and is so seldom used for its intended purpose that Juan Linietsky was even considering removing it to alleviate confusion back in 2018 (but never did because some people do legitimately use it for its intended purpose). So, people seem to run into the issue a decent amount and I can definitely see why.

[duongvituan]

Thanks for your sharing and i'm glad for your help :).