Support BufferRequests in HttpClient based backends #3958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the HttpCompletionOptions to support the
BufferRequests
(--http-enable-buffering
) setting inHttpClient
based backends.Both .Net and Mono appear to treat
HttpCompletionOption.ResponseContentRead
as a signal to cache the response, andHttpCompletionOption.ResponseHeadersRead
as a signal to not cache the response.Note that this will also change the default behavior to not buffer, as previously
HttpClient
based backends (which looks like it is just theMicrosoftGraphBackend
's derivatives) would use the default, which was to have responses buffered.This change is largely motivated by Duplicati throwing out of memory errors which seem to be related to attempting to allocate a memory stream to cache the full response when running on a Raspberry Pi with limited memory.