Add indices to Block table to improve query performance #4171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index on Block.Size improves the performance of the query that checks that the user has not altered the block size of the backup configuration. The index on Block.Hash and Block.VolumeID improves the performance of the query that obtains the blocklists. There are anecdotes that these indices can drastically improve performance (queries that used to take hours completed in seconds with the index): https://forum.duplicati.com/t/repairing-a-big-database/8174/4 duplicati#3884 (comment) This fixes issue duplicati#3884.
|
This pull request has been mentioned on Duplicati. There might be relevant details there: https://forum.duplicati.com/t/repairing-a-big-database/8174/13 |
|
This pull request has been mentioned on Duplicati. There might be relevant details there: https://forum.duplicati.com/t/performance-tips-what-is-normal/6471/13 |
|
This pull request has been mentioned on Duplicati. There might be relevant details there: |
|
This pull request has been mentioned on Duplicati. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index on
Block.Sizeimproves the performance of the query that checks that the user has not altered the block size of the backup configuration.The index on
Block.HashandBlock.VolumeIDimproves the performance of the query that obtains the blocklists.There are anecdotes that these indices can drastically improve performance (queries that used to take hours completed in seconds with the index):
https://forum.duplicati.com/t/repairing-a-big-database/8174/4
#3884 (comment)
This fixes issue #3884.