DURACLOUD-1313: Stops synctool retrying hundreds of times #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 10, 2021 15:04
In order to overcome this issue. spring-projects/spring-boot#11225 Also had to pull back jaxb-runtime, as this is now pinned by hibernate.
We were previously creating 3 nested retry loops, first in DuraStoreSyncEndpoint, then again in ContentIterator, ultimately calling the `getSpace` method, which is already a `Retriable`! We now solely rely on the retry loop created by `ContentStore.getSpace()`.
fozboz
changed the title
Reverted ContentIterator. Switched out the call in spaceExists() to use getSpaceACLs() instead of getSpaceContents() so it doesn't end up in a double loop when the space does not exist (and therefore returns an error faster).
bbranan
reviewed
Nov 11, 2021
| "activity other than sync there is the possibility " + | ||
| "of data loss."); | ||
| } | ||
| Map<String, AclType> acls = |
There was a problem hiding this comment.
Since the return value isn't used for anything, there's really no need to capture it in a variable (and leaving it out means there's no need to import AclTye either).
There is no need to do this because the return value is never used.
bbranan
pushed a commit
to duracloud/duracloud-db
that referenced
this pull request
Nov 11, 2021
Part of work on https://duracloud.atlassian.net/browse/DURACLOUD-1313, matching hibernate version update in duracloud/duracloud#154
When running in command-line mode, it is too easy to mis-type the space name. Next thing you know, you've got tons of content in the incorrect space. Synctool will now error if the space does not exist.
bbranan
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DURACLOUD-1313
Also includes additional commit that bumps hibernate version to resolve this issue.