Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DURACLOUD-1313: Stops synctool retrying hundreds of times #154

Merged
merged 5 commits into from
Nov 11, 2021

Commits on Nov 10, 2021

  1. Bump hibernate version

    In order to overcome this issue.
    spring-projects/spring-boot#11225
    
    Also had to pull back jaxb-runtime, as this is now pinned by hibernate.
    Andy Foster committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    4555e4a View commit details
    Browse the repository at this point in the history
  2. Stop syncclient from retrying hundreds of times

    We were previously creating 3 nested retry loops, first in
    DuraStoreSyncEndpoint, then again in ContentIterator, ultimately
    calling the `getSpace` method, which is already a `Retriable`! We
    now solely rely on the retry loop created by `ContentStore.getSpace()`.
    Andy Foster committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    985caa8 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. Revert ContentIterator and change spaceExists method

    Reverted ContentIterator.
    
    Switched out the call in spaceExists() to use getSpaceACLs() instead of
    getSpaceContents() so it doesn't end up in a double loop when the space
    does not exist (and therefore returns an error faster).
    Andy Foster committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    f4df17d View commit details
    Browse the repository at this point in the history
  2. Don't capture acls in a variable

    There is no need to do this because the return value is never used.
    Andy Foster committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    90e5da4 View commit details
    Browse the repository at this point in the history
  3. Do not create space if it does not exist

    When running in command-line mode, it is too easy to mis-type the space
    name. Next thing you know, you've got tons of content in the incorrect
    space. Synctool will now error if the space does not exist.
    Andy Foster committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    2ff0213 View commit details
    Browse the repository at this point in the history