Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag the Crackteam and Project #11

Closed
duraki opened this issue Aug 3, 2020 · 8 comments
Closed

Tag the Crackteam and Project #11

duraki opened this issue Aug 3, 2020 · 8 comments
Assignees

Comments

@duraki
Copy link
Owner

duraki commented Aug 3, 2020

Tied to #8 so we can track it. This will remove "Days left until expiration" and will be replaced with crackteam and project name.

@elijahtsai
Copy link
Collaborator

elijahtsai commented Nov 1, 2020

I think I will make this happened in version v70. this is gonna be a big construction project for us.

  • Remove "Days left until expiration"
  • Remove "Register now"
  • Replace label with project name.
  • Make some change in Register panel.

@duraki
Copy link
Owner Author

duraki commented Nov 1, 2020

Yes, v70 really deserves this feature to be implemented. I'm with you on this one. I think we can tackle first and third from your list by doing it over *.nib files we reverse engineered a few months early? We just need to make sure the offset size is correct and we don't overwrite or underwrite the byte positions. Right now, when I open Sketch it says "21 days left - Register now". First one is counter + NSString implemented inside the Sketch.app binary while the Register now is in the nib / UI files from Sketch directory.

I can try to implement this feature too so we can collab and push together.

@duraki duraki pinned this issue Dec 4, 2020
@duraki
Copy link
Owner Author

duraki commented Dec 8, 2020

I'm sorting Crackteam tag this week hopefully. :) Then we can go w/ v70 at least.

@duraki
Copy link
Owner Author

duraki commented Dec 13, 2020

Changing the Registration Window

Ok tagging the crakcteam as per this #11 (comment). Steps taken are visible below (tested under clean Sketch v69):

FIrst thing first, I searched upon few substrings in Sketch.app bundle directory.

$  grep -R "SK3" */**
Contents/Resources/zh-Hans.lproj/MSRegistrationWindow.strings:/* Class = "CocoaBindingsConnection"; ibShadowedIsNilPlaceholder = "SK3-0000-0000-0000-0000-0000"; ObjectID = "kCf-Hg-sTQ"; */
Contents/Resources/zh-Hans.lproj/MSRegistrationWindow.strings:"kCf-Hg-sTQ.ibShadowedIsNilPlaceholder" = "SK3-0000-0000-0000-0000-0000";
Contents/Resources/zh-Hans.lproj/MSRegistrationWindow.strings:/* Class = "NSTextFieldCell"; placeholderString = "SK3-0000-0000-0000-0000-0000"; ObjectID = "yfB-jh-Is0"; */
Contents/Resources/zh-Hans.lproj/MSRegistrationWindow.strings:"yfB-jh-Is0.placeholderString" = "SK3-0000-0000-0000-0000-0000";

So, instead of editing raw Registration Window nib/xib via NibUnlocker from Charles, I figured out that these references are reused through resources / localization.

So I copied this MSRegistrationWindow.strings class and pasted it upon en.lproj/ (default localization), like so, and edited the localization:

$ cd /Applications/Sketch.app 
$ cp Contents/Resources/zh-Hans.lproj/MSRegistrationWindow.strings Contents/Resources/en.lproj/

# => continue editing string xrefs
$ vim Contents/Resources/en.lproj/MSRegistrationWindow.strings

All changes as follows:

MSRegistrationWindow.txt

(Copy this file to /Applications/Sketch.app/Contents/Resources/en.lproj/ as MSRegistrationWindow.strings)


End Results

Screenshot 2020-12-13 at 15 41 35

@duraki
Copy link
Owner Author

duraki commented Dec 13, 2020

MSRegistrationWindow.txt

(fixed)

Tested on: v69.2, v70, v70.2

@elijahtsai
Copy link
Collaborator

patch worked on 70.2

@elijahtsai
Copy link
Collaborator

working on 70.3😵

@elijahtsai
Copy link
Collaborator

Implemented!

@elijahtsai elijahtsai unpinned this issue Dec 27, 2020
@elijahtsai elijahtsai removed the New Version Request New feature or request is need label Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants