Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on 67.1 or 67.2 #8

Closed
kuthulhu opened this issue Aug 2, 2020 · 3 comments
Closed

Doesn't work on 67.1 or 67.2 #8

kuthulhu opened this issue Aug 2, 2020 · 3 comments

Comments

@kuthulhu
Copy link

kuthulhu commented Aug 2, 2020

I am getting no error after script run. App works normally after script. But I still get "x Days Left - Register Now" on right corner in any document and counts down each day as before. It is like script did nothing.

I uninstall currently installed version, downloaded new one from sketch website. Deleted keychain entries before each install. Tried both 67.1 and 67.2. Tried "sudo ./sketchcrapp". Is there anything else I can do?

@elijahtsai elijahtsai added the Inprogress We are working on this issue/pull request, stay tuned for further notice. label Aug 2, 2020
@elijahtsai
Copy link
Collaborator

Hi @kuthulhu, If you successfully patched the "Register Now" label you got is normal, you can ignore it. the only problem is that after trial day over will you get Register license window pop-up? If not then we good, If yes then we may discuss even more on this problem. No matter the answer is yes or no please tell us the result. Thanks.

@duraki
Copy link
Owner

duraki commented Aug 3, 2020

It's normal to see that. The patch is directly related to binary offsets for checking number of days on backend side, but not for visible UIView//UILabel related to presentation model. We will add this to README. We might fix it in the future :)

@duraki
Copy link
Owner

duraki commented Aug 3, 2020

We will continue to track this change in separate issue at #11-.

@duraki duraki closed this as completed Aug 3, 2020
@elijahtsai elijahtsai added need enhancement and removed Inprogress We are working on this issue/pull request, stay tuned for further notice. need issuer response labels Aug 3, 2020
Repository owner locked and limited conversation to collaborators Aug 3, 2020
Repository owner unlocked this conversation Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants