Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse test code to eliminate repetition #71

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Reuse test code to eliminate repetition #71

merged 5 commits into from
Jul 12, 2023

Conversation

miloszm
Copy link
Contributor

@miloszm miloszm commented Jul 11, 2023

Reuse test code to eliminate repetition:
methods compute_random_license and compute_citadel_parameters are duplicated
in bench and in tests of Citadel, as well as in circuits/license tests in Rusk and in contracts/license tests in Rusk.
This PR attempts to address this 4x repetition.

@miloszm miloszm requested a review from xevisalle July 11, 2023 14:43
xevisalle
xevisalle approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miloszm miloszm merged commit 99f8a64 into main Jul 12, 2023
6 checks passed
@miloszm miloszm deleted the main-rc branch July 12, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xevisalle xevisalle xevisalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miloszm @xevisalle