Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to the new and improved reward strategy #1320

Closed
autholykos opened this issue Mar 2, 2022 · 4 comments · Fixed by #1370
Closed

Adapt to the new and improved reward strategy #1320

autholykos opened this issue Mar 2, 2022 · 4 comments · Fixed by #1370

Comments

@autholykos
Copy link
Member

autholykos commented Mar 2, 2022

What is this for

This is a followup after dusk-network/rusk#614

herr-seppia added a commit that referenced this issue Mar 7, 2022
Fee() is used to RangeSort txs extraction

Resolves #1320
@autholykos autholykos added mark:testnet mark:next tasks playing a role in the strategic plans and removed mark:testnet mark:next tasks playing a role in the strategic plans labels Mar 25, 2022
@ureeves
Copy link
Member

ureeves commented Apr 6, 2022

The payload of the coinbase, in the context of this change, will be:

pub struct CoinbasePayload {
    pub block_height: u64,
    pub generator: PublicKey,
}

@herr-seppia
Copy link
Member

@ureeves

I know we discussed these change together, but a question just raise in my mind:
How can the explorer show information about the block reward without derive them using txs fees and block height?

@ureeves
Copy link
Member

ureeves commented Apr 6, 2022

In my view this should be computed from the transaction fees and the block height. If we don't want to use those - and I would ask why not - we could have Rusk return said information to the consensus program. Maybe some additional information in the return of a state transition?

@herr-seppia
Copy link
Member

It's just a matter of making infos explicitly available in the block.
If we want to go for derive them, we don't need to change anything in the block header (Generator and blockheight are already there)

Btw including those info in the header and as return of EST&co should enforce checks by dusk-blockchain during the block acceptance (I'm saying "enforce" because everything is implicitly checked by the statehash match)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants