Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default config values are not loaded #1419

Closed
herr-seppia opened this issue Jun 16, 2022 · 0 comments · Fixed by #1420
Closed

Default config values are not loaded #1419

herr-seppia opened this issue Jun 16, 2022 · 0 comments · Fixed by #1420
Assignees
@herr-seppia
Labels
mark:testnet type:bug Something isn't working

Comments

@herr-seppia
Copy link
Member

Describe the bug
The default configuration values defined in Loader.init() are not used
If no BlockGasLimit is set into the config.toml the used gasLimit is 0 instead of DefaultBlockGasLimit

dusk-blockchain/pkg/config/loader.go

Line 265 in 3ea959e

r.State.BlockGasLimit = DefaultBlockGasLimit

To Reproduce
Run test-harness-tps over that branch and retrieve the gasLimit using GraphQL, it

Expected behaviour
If no BlockGasLimit is set into the config.toml the used gasLimit should be DefaultBlockGasLimit

Additional context
This has been discovered during the development of #1418
@herr-seppia herr-seppia added the type:bug Something isn't working label Jun 16, 2022
@herr-seppia herr-seppia self-assigned this Jun 16, 2022
herr-seppia added a commit that referenced this issue Jun 16, 2022
@herr-seppia
Fix configuration loader
8c61afe 
- Remove Registry initialization from `cfg.Load` method
- Add test to check default values

Resolves #1419
@herr-seppia herr-seppia mentioned this issue Jun 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@herr-seppia herr-seppia

Labels
mark:testnet type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make BlockGasLimit configurable dusk-network/dusk-blockchain
1 participant
@herr-seppia