Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove genesis consistency checks #1464

Closed
herr-seppia opened this issue Sep 13, 2022 · 0 comments · Fixed by #1465
Closed

Remove genesis consistency checks #1464

herr-seppia opened this issue Sep 13, 2022 · 0 comments · Fixed by #1465

Comments

@herr-seppia
Copy link
Member

Describe "Why" this is needed
Atm of writing, dusk-blockchain repo use to hardcode the values of rusk's state-root and the derived genesis-hash.
This were introduced in order to mitigate the possibility of being error-prone after a breaking change upgrade.
Since we introduced the protocol and rusk versions, the genesis consistency checks should not be required anymore.

ℹ️ Dusk-blockchain shall accept any state-root provided by rusk itself if the chain db is at block 0.
⚠️ The node is expected to fail to accept blocks if the connected rusk is using a wrong genesis state root.

Describe alternatives you've considered
N/A

Additional context
N/A

herr-seppia added a commit that referenced this issue Sep 14, 2022
herr-seppia added a commit that referenced this issue Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant