Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate graphql with transaction data #1289

Merged
merged 9 commits into from
Feb 14, 2022
Merged

Populate graphql with transaction data #1289

merged 9 commits into from
Feb 14, 2022

Conversation

goshawk-3
Copy link
Contributor

fixes #1284

@goshawk-3 goshawk-3 marked this pull request as draft February 11, 2022 08:09
@codecov-commenter
Copy link

Codecov Report

Merging #1289 (751804e) into master (828364b) will decrease coverage by 8.46%.
The diff coverage is 49.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
- Coverage   50.51%   42.05%   -8.47%     
==========================================
  Files         145      144       -1     
  Lines        7544     9017    +1473     
==========================================
- Hits         3811     3792      -19     
- Misses       3066     4654    +1588     
+ Partials      667      571      -96     
Impacted Files Coverage Δ
pkg/config/genesis/config.go 0.00% <0.00%> (ø)
pkg/core/candidate/validator.go 64.00% <ø> (+6.85%) ⬆️
pkg/core/chain/mock.go 9.09% <ø> (+0.75%) ⬆️
...nsensus/blockgenerator/candidate/blockgenerator.go 0.00% <0.00%> (-64.29%) ⬇️
...core/consensus/blockgenerator/candidate/genesis.go 0.00% <0.00%> (-69.24%) ⬇️
...kg/core/consensus/blockgenerator/candidate/mock.go 0.00% <0.00%> (ø)
...ore/consensus/blockgenerator/candidate/testutil.go 0.00% <0.00%> (-90.91%) ⬇️
pkg/core/consensus/comms.go 0.00% <0.00%> (ø)
pkg/core/consensus/fixtures.go 0.00% <0.00%> (ø)
pkg/core/consensus/header/header.go 24.50% <0.00%> (+2.41%) ⬆️
... and 187 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ddd70...751804e. Read the comment docs.

@goshawk-3 goshawk-3 marked this pull request as ready for review February 11, 2022 12:04
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFC in reward calculation

pkg/core/mempool/mempool.go Show resolved Hide resolved
pkg/gql/query/blocks.go Show resolved Hide resolved
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goshawk-3 goshawk-3 merged commit 49e2398 into master Feb 14, 2022
@goshawk-3 goshawk-3 deleted the fix-1284 branch February 14, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include the decoded payload fields into GraphQL
3 participants