Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode transparent notes amount #1296

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

herr-seppia
Copy link
Member

Resolves #1292

@codecov-commenter
Copy link

Codecov Report

Merging #1296 (bbdba47) into master (828364b) will decrease coverage by 8.64%.
The diff coverage is 48.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
- Coverage   50.51%   41.87%   -8.65%     
==========================================
  Files         145      144       -1     
  Lines        7544     9048    +1504     
==========================================
- Hits         3811     3789      -22     
- Misses       3066     4686    +1620     
+ Partials      667      573      -94     
Impacted Files Coverage Δ
pkg/config/genesis/config.go 0.00% <0.00%> (ø)
pkg/core/candidate/validator.go 64.00% <ø> (+6.85%) ⬆️
pkg/core/chain/mock.go 9.09% <ø> (+0.75%) ⬆️
...nsensus/blockgenerator/candidate/blockgenerator.go 0.00% <0.00%> (-64.29%) ⬇️
...core/consensus/blockgenerator/candidate/genesis.go 0.00% <0.00%> (-69.24%) ⬇️
...kg/core/consensus/blockgenerator/candidate/mock.go 0.00% <0.00%> (ø)
...ore/consensus/blockgenerator/candidate/testutil.go 0.00% <0.00%> (-90.91%) ⬇️
pkg/core/consensus/comms.go 0.00% <0.00%> (ø)
pkg/core/consensus/fixtures.go 0.00% <0.00%> (ø)
pkg/core/consensus/header/header.go 24.50% <0.00%> (+2.41%) ⬆️
... and 187 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef11b7b...bbdba47. Read the comment docs.

Copy link
Member

@autholykos autholykos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit c8c1c43 into master Feb 15, 2022
@herr-seppia herr-seppia deleted the decode-transparent-notes-1292 branch February 15, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read block reward value from Distribute transaction
3 participants