Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check transaction GasLimit against block GasLimit #1316

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Check transaction GasLimit against block GasLimit #1316

merged 1 commit into from
Mar 1, 2022

Conversation

herr-seppia
Copy link
Member

Resolves #1306

ureeves
ureeves approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it odd that we're rejecting transactions that still fit in the block with >=, but if this is decision LGTM.

@herr-seppia herr-seppia merged commit db46259 into master Mar 1, 2022
@herr-seppia herr-seppia deleted the tx-blockgaslimit-1306 branch March 1, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ureeves ureeves ureeves approved these changes

@autholykos autholykos Awaiting requested review from autholykos

@goshawk-3 goshawk-3 Awaiting requested review from goshawk-3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't allow transactions equal or higher than block gas limit in the mempool
2 participants
@herr-seppia @ureeves