Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain transaction status #1332

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Retain transaction status #1332

merged 5 commits into from
Mar 8, 2022

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Mar 8, 2022

  • Update to dusk-protobuf v0.3.10
  • Parse error from rusk ExecutedTransaction
  • Encode/Decode tx Error into chain database
  • Add txerror field graphQL API

Resolves #1309

@herr-seppia herr-seppia self-assigned this Mar 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #1332 (cac68eb) into master (828364b) will decrease coverage by 8.60%.
The diff coverage is n/a.

❗ Current head cac68eb differs from pull request most recent head cb4047d. Consider uploading reports for the commit cb4047d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1332      +/-   ##
==========================================
- Coverage   50.51%   41.91%   -8.61%     
==========================================
  Files         145      144       -1     
  Lines        7544     9202    +1658     
==========================================
+ Hits         3811     3857      +46     
- Misses       3066     4760    +1694     
+ Partials      667      585      -82     
Impacted Files Coverage Δ
pkg/core/consensus/testing/node.go 0.00% <0.00%> (-93.55%) ⬇️
...ore/consensus/blockgenerator/candidate/testutil.go 0.00% <0.00%> (-90.91%) ⬇️
pkg/core/consensus/testing/utils.go 0.00% <0.00%> (-75.61%) ⬇️
...core/consensus/blockgenerator/candidate/genesis.go 0.00% <0.00%> (-69.24%) ⬇️
...nsensus/blockgenerator/candidate/blockgenerator.go 0.00% <0.00%> (-64.29%) ⬇️
pkg/gql/query/transactions.go 12.60% <0.00%> (-53.38%) ⬇️
pkg/util/nativeutils/eventbus/eventbus.go 57.14% <0.00%> (-42.86%) ⬇️
pkg/rpc/client/session.go 26.19% <0.00%> (-42.39%) ⬇️
pkg/rpc/client/client.go 3.73% <0.00%> (-36.61%) ⬇️
pkg/core/consensus/reduction/aggregator.go 56.25% <0.00%> (-35.06%) ⬇️
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 910a144...cb4047d. Read the comment docs.

@herr-seppia herr-seppia marked this pull request as ready for review March 8, 2022 15:27
Copy link
Member

@autholykos autholykos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@goshawk-3 goshawk-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit 3255022 into master Mar 8, 2022
@herr-seppia herr-seppia deleted the tx-status-1309 branch March 8, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction status should be retained
4 participants