Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle block acceptance on specified conditions #1333

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Conversation

goshawk-3
Copy link
Contributor

fixes #1331

pkg/core/chain/chain.go Show resolved Hide resolved
pkg/core/chain/chain.go Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #1333 (1edff3c) into master (828364b) will decrease coverage by 8.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
- Coverage   50.51%   41.59%   -8.93%     
==========================================
  Files         145      144       -1     
  Lines        7544     9216    +1672     
==========================================
+ Hits         3811     3833      +22     
- Misses       3066     4796    +1730     
+ Partials      667      587      -80     
Impacted Files Coverage Δ
pkg/core/consensus/testing/node.go 0.00% <0.00%> (-93.55%) ⬇️
...ore/consensus/blockgenerator/candidate/testutil.go 0.00% <0.00%> (-90.91%) ⬇️
pkg/core/consensus/testing/utils.go 0.00% <0.00%> (-75.61%) ⬇️
...core/consensus/blockgenerator/candidate/genesis.go 0.00% <0.00%> (-69.24%) ⬇️
...nsensus/blockgenerator/candidate/blockgenerator.go 0.00% <0.00%> (-64.29%) ⬇️
pkg/gql/query/transactions.go 12.60% <0.00%> (-53.38%) ⬇️
pkg/rpc/client/session.go 21.42% <0.00%> (-47.15%) ⬇️
pkg/util/nativeutils/eventbus/eventbus.go 57.14% <0.00%> (-42.86%) ⬇️
pkg/rpc/client/client.go 3.73% <0.00%> (-36.61%) ⬇️
pkg/core/consensus/reduction/aggregator.go 56.25% <0.00%> (-35.06%) ⬇️
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 910a144...1edff3c. Read the comment docs.

Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goshawk-3 goshawk-3 merged commit 99b06f3 into master Mar 9, 2022
@goshawk-3 goshawk-3 deleted the fix-1331 branch March 9, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow down consensus agreement time suitably
3 participants