Refactor generation component to search for bid values by itself, without needing user input #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…provisioner components
…id has been made yet
- Remove the need for the provisioner component to see a stake before starting - Simplify the bidretriever and keep it isolated in the generation package - Launch provisioner component in goroutine
Codecov Report
@@ Coverage Diff @@
## testnet #25 +/- ##
==========================================
Coverage ? 55.02%
==========================================
Files ? 118
Lines ? 6197
Branches ? 0
==========================================
Hits ? 3410
Misses ? 2194
Partials ? 593
Continue to review full report at Codecov.
|
|
@julesdesmit Do you think we can start adding more debug-level logging entries? E.g |
|
@ggoranov Sure, good point. I will go over the changes and add logging. |
jules
added a commit
that referenced
this pull request
Aug 26, 2019
|
@ggoranov added |
ggoranov
approved these changes
Aug 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2, and fixes #19, by making the generation component work much like the provisioner component does - the initiation code has been refactored to be more generic, allowing it to be used by both sides of the consensus codebase.
With this PR merged, a user would simply have to use
startblockgeneratorwith no TxID supplied, to start generating blocks. And, much like the provisioner component, it can be used before sending a bid, as the generation component will find it later on if needed.This MR should also fix #30.