Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus: change bls12_381-bls to use parallel feature #1160

Merged
merged 2 commits into from
Jun 19, 2024
Merged

consensus: change bls12_381-bls to use parallel feature #1160

merged 2 commits into from
Jun 19, 2024

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Nov 28, 2023 •
edited
Loading

Previous bench

verify_block_cert/verify_block_cert/1 prov
                        time:   [6.8250 ms 6.8550 ms 6.8912 ms]

verify_block_cert/verify_block_cert/30 prov
                        time:   [52.643 ms 52.846 ms 53.063 ms]

verify_block_cert/verify_block_cert/64 prov
                        time:   [78.349 ms 78.666 ms 79.005 ms]

verify_block_cert/verify_block_cert/256 prov
                        time:   [111.34 ms 111.53 ms 111.75 ms]

verify_block_cert/verify_block_cert/1000 prov
                        time:   [118.67 ms 119.00 ms 119.39 ms]

PR bench
image

Benchmarked on Apple M1 Pro
See also #1149

@herr-seppia herr-seppia changed the base branch from master to bench_verify_block November 28, 2023 18:00
@herr-seppia herr-seppia changed the title WIP: Apk parallel consensus: change bls12_381-sign to use parallel feature Nov 28, 2023
@herr-seppia herr-seppia force-pushed the bench_verify_block branch 2 times, most recently from 1854311 to 06b7c2a Compare December 1, 2023 13:42
Base automatically changed from bench_verify_block to master December 1, 2023 14:39
@herr-seppia herr-seppia force-pushed the apk_parallel branch 2 times, most recently from e10a1fc to c9ed17c Compare January 4, 2024 17:14
@herr-seppia herr-seppia self-assigned this Feb 8, 2024
@HDauven HDauven linked an issue Apr 9, 2024 that may be closed by this pull request
Investigate block acceptance timing #1149
Closed
@herr-seppia herr-seppia changed the title consensus: change bls12_381-sign to use parallel feature consensus: change bls12_381-bls to use parallel feature May 7, 2024
@herr-seppia herr-seppia marked this pull request as ready for review May 7, 2024 08:36
goshawk-3
goshawk-3 reviewed May 8, 2024
View reviewed changes
consensus/Cargo.toml Outdated Show resolved Hide resolved
moCello
moCello previously approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement

@herr-seppia herr-seppia merged commit 862adcb into master Jun 19, 2024
8 checks passed
@herr-seppia herr-seppia deleted the apk_parallel branch June 19, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDauven HDauven HDauven approved these changes

@ureeves ureeves Awaiting requested review from ureeves

@autholykos autholykos Awaiting requested review from autholykos

@goshawk-3 goshawk-3 Awaiting requested review from goshawk-3

@moCello moCello Awaiting requested review from moCello

Assignees

@herr-seppia herr-seppia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate block acceptance timing
5 participants
@herr-seppia @autholykos @HDauven @moCello @goshawk-3