Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quit program if 3 times wrong recovery phrase is given during recovery process #49

Closed
sophielouisefeith opened this issue May 30, 2022 · 1 comment
Closed

Quit program if 3 times wrong recovery phrase is given during recovery process #49

sophielouisefeith opened this issue May 30, 2022 · 1 comment
Assignees
@sophielouisefeith
Labels
area:wallet Issues related to the wallet functionalities exposed by the node mark:testnet Tactical issues related to currently deployed Testnet module:rusk-wallet

Comments

@sophielouisefeith
Copy link
Contributor

sophielouisefeith commented May 30, 2022 •
edited

Describe what you want implemented
The program should quit after 3 times a wrong phase phrase

Describe "Why" this is needed
If the user is not able to fill in the correct recovery phrase, the program will exit
@sophielouisefeith sophielouisefeith self-assigned this May 30, 2022
@sophielouisefeith sophielouisefeith changed the title Give the user the option to exit program while recovering wallet Program should quit if wrong seed phrase is given Aug 22, 2022
@sophielouisefeith
Copy link
Contributor Author

Updated issue, after new structure of the wallet

@sophielouisefeith sophielouisefeith added area:wallet Issues related to the wallet functionalities exposed by the node module:rusk-wallet mark:testnet Tactical issues related to currently deployed Testnet labels Aug 22, 2022
@sophielouisefeith sophielouisefeith mentioned this issue Sep 1, 2022
Closed
sophielouisefeith added a commit that referenced this issue Sep 21, 2022
@sophielouisefeith
Optimise error handling
243da1d 
Added

Add retrying password to improve UX [#46]
Add retrying recovery phrase to improve UX [#49]

Changed

Change error handling to use the `anyhow` crate in `bin` [#87]
Change error handling to use the `thiserror` crate in `lib` [#87]

Resolve #87 #46 #49
sophielouisefeith added a commit that referenced this issue Sep 21, 2022
@sophielouisefeith
Optimise error handling
aa02975 
Added

Add retrying password to improve UX [#46]
Add retrying recovery phrase to improve UX [#49]

Changed

Change error handling to use the `anyhow` crate in `bin` [#87]
Change error handling to use the `thiserror` crate in `lib` [#87]

Resolve #87 #46 #49
@sophielouisefeith sophielouisefeith mentioned this issue Sep 21, 2022
Merged
sophielouisefeith added a commit that referenced this issue Sep 21, 2022
@sophielouisefeith
Optimise error handling
b903876 
Added

Add retrying password to improve UX [#46]
Add retrying recovery phrase to improve UX [#49]

Changed

Change error handling to use the `anyhow` crate in `bin` [#87]
Change error handling to use the `thiserror` crate in `lib` [#87]

Resolve #87 #46 #49
sophielouisefeith added a commit that referenced this issue Sep 22, 2022
@sophielouisefeith
Optimise error handling
2532b66 
Added

Add retrying password to improve UX [#46]
Add retrying recovery phrase to improve UX [#49]

Changed

Change error handling to use the `anyhow` crate in `bin` [#87]
Change error handling to use the `thiserror` crate in `lib` [#87]

Resolve #87 #46 #49
@sophielouisefeith sophielouisefeith changed the title Program should quit if wrong seed phrase is given Delete wallet after 3 x wrong seed phrase Sep 22, 2022
@sophielouisefeith sophielouisefeith changed the title Delete wallet after 3 x wrong seed phrase Delete wallet after 3 times wrong seed phrase during recovery process Sep 22, 2022
@sophielouisefeith sophielouisefeith changed the title Delete wallet after 3 times wrong seed phrase during recovery process Quit program if 3 times wrong recovery phrases is given during recovery process Sep 22, 2022
@sophielouisefeith sophielouisefeith changed the title Quit program if 3 times wrong recovery phrases is given during recovery process Quit program if 3 times wrong recovery phrase is given during recovery process Sep 22, 2022
sophielouisefeith added a commit that referenced this issue Sep 22, 2022
@sophielouisefeith
Improve UX on password's retrying scenarios
5c9d432 
• Change program behavior to quit if wrong seed phrase is given [#49]
• Change program behavior to have three attempts for entering a password [#46]

Resolves #46, #49
@sophielouisefeith sophielouisefeith mentioned this issue Sep 22, 2022
Merged
sophielouisefeith added a commit that referenced this issue Sep 22, 2022
@sophielouisefeith
Improve UX on password's retrying scenarios
9db7a15 
• Change program behavior to quit if wrong seed phrase is given [#49]
• Change program behavior to have three attempts for entering a password [#46]

Resolves #46, #49
sophielouisefeith added a commit that referenced this issue Sep 22, 2022
@sophielouisefeith
Improve UX on password's retrying scenarios
c73448f 
• Change program behavior to quit if wrong seed phrase is given [#49]
• Change program behavior to have three attempts for entering a password [#46]

Resolves #46, #49
sophielouisefeith added a commit that referenced this issue Sep 27, 2022
@sophielouisefeith
Improve UX on password's retrying scenarios
b3aab8d 
• Change program behavior to quit if wrong seed phrase is given [#49]
• Change program behavior to have three attempts for entering a password [#46]

Resolves #46, #49
sophielouisefeith added a commit that referenced this issue Sep 27, 2022
@sophielouisefeith
Improve UX on password's retrying scenarios
461bbf1 
• Change program behavior to quit if wrong seed phrase is given [#49]
• Change program behavior to have three attempts for entering a password [#46]

Resolves #46, #49
@herr-seppia herr-seppia mentioned this issue Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sophielouisefeith sophielouisefeith

Labels
area:wallet Issues related to the wallet functionalities exposed by the node mark:testnet Tactical issues related to currently deployed Testnet module:rusk-wallet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sophielouisefeith