feat: find the icon in a map before ligature #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fa-icon` will now look for the icon in the map before leveraing ligature of fonts. This may solve the issue of icons in Brands not showing up.
duskmoon314
added
enhancement
|
Some icons only have a solid version. I have yet to consider how to solve this. E.g. arrow-trend-down, arrow-trend-up... Here is an image showing the problem 
|
duskmoon314
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fa-iconwill now look for the icon in the map before leveraging the ligature of fonts. This may solve the issue of icons in Brands not showing up.May solve #5